Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] Review callback gas limit issue #154

Closed
hellwolf opened this issue Dec 16, 2020 · 3 comments
Closed

[ETHEREUM-CONTRACTS] Review callback gas limit issue #154

hellwolf opened this issue Dec 16, 2020 · 3 comments
Assignees
@hellwolf
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Security Security related system improvements
Milestone
ethereum-contract...

Comments

@hellwolf
Copy link
Contributor

hellwolf commented Dec 16, 2020 •
edited
Loading

Synopsis

Currently callbacks have a CALLBACK_GAS_LIMIT of 3M gas, and _callCallback should detect the genuine out of gas callback issue vs. out of gas grievance attacks.

Co-reviewer: Hadrien

References
@hellwolf hellwolf added the Type: Security Security related system improvements label Dec 16, 2020
@hellwolf hellwolf added this to the v1.0 milestone Dec 16, 2020
@hellwolf hellwolf removed this from the [email protected] milestone Feb 19, 2021
@hellwolf hellwolf changed the title Review callback gas limit issue [ETHEREUM-CONTRACTS] Review callback gas limit issue Sep 13, 2021
@hellwolf hellwolf added this to the ethereum-contracts security milestone Dec 5, 2022
@hellwolf hellwolf added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Aug 23, 2023
@vmichalik
Copy link
Collaborator

@hellwolf is it possible to add more details here do you think and put into tech debt? or better to close

@hellwolf
Copy link
Contributor Author

hellwolf commented Sep 5, 2023

Moving to technical debt, waiting for adding a section to https://github.com/superfluid-finance/protocol-monorepo/wiki/About-Call-Proxies

@hellwolf hellwolf added the Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity label Jan 18, 2024
@hellwolf hellwolf removed the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Mar 11, 2024
@hellwolf
Copy link
Contributor Author

hellwolf commented Jul 8, 2024

Concluded with CallbackUtils #1979

@hellwolf hellwolf closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellwolf hellwolf

Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Type: Security Security related system improvements
Projects
None yet
Milestone
ethereum-contracts security
Development

No branches or pull requests
3 participants
@hellwolf @Amxx @vmichalik