Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] PoolNFTs: remove try/catch #1897

Closed
1 task done
d10r opened this issue Mar 19, 2024 · 0 comments · Fixed by #1979
Closed
1 task done

[ETHEREUM-CONTRACTS] PoolNFTs: remove try/catch #1897

d10r opened this issue Mar 19, 2024 · 0 comments · Fixed by #1979
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Quality Related to the quality topic Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps

Comments

@d10r
Copy link
Collaborator

d10r commented Mar 19, 2024 •
edited by hellwolf
Loading

What & Why

In #1879 we fixed an issue with the FlowNFTs: the hooks for minting and burning were wrapped in a try/catch and could fail with outofgas. This happened despite code supposed to avoid exactly that.
The Pool NFTs use the same mechanism. We haven't yet observed such internal reverts, but currently can't be confident the same could happen.

AC

  • Remove try/catch from PoolNFT hooks & make sure there's no code path where it could revert
@d10r d10r added Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Quality Related to the quality topic Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps labels Mar 19, 2024
@hellwolf hellwolf linked a pull request Jul 3, 2024 that will close this issue
Lib CallbackUtils & Remove PoolNFT callback try/catch #1979
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project: PROTOCOL-EVMv1 Superfluid protocol EVM v1 implementation in Solidity Tag: Quality Related to the quality topic Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lib CallbackUtils & Remove PoolNFT callback try/catch superfluid-finance/protocol-monorepo
1 participant
@d10r