Add saved payment method support for SEPA. #7449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKMANIFESTDEXARSC |
jaynewstrom-stripe
requested review from
awush-stripe,
jameswoo-stripe,
samer-stripe and
yuki-stripe
There was a problem hiding this comment.
Why is this not centered text compared to other mandate texts?
There was a problem hiding this comment.
Updated.
| }.getOrNull()?.merchantName | ||
|
|
||
| if (merchantName == null) { | ||
| finish() |
There was a problem hiding this comment.
Should we log a message for easier debugging for integrators?
There was a problem hiding this comment.
The only time this could happen is if you don't supply args. I can log a message, but this shouldn't ever happen. This is just a safety to prevent the app from crashing when attackers try to launch our activity illegally.
| // we present the mandate directly. | ||
| sepaMandateActivityLauncher.launch( | ||
| SepaMandateContract.Args( | ||
| merchantName = state.config?.merchantDisplayName ?: "" |
There was a problem hiding this comment.
This doesn't seem right, the activity is expecting a non null merchant name, what makes an empty string better here?
There was a problem hiding this comment.
The only time this could be null is when the config is null, which isn't possible in practice. So the empty string should never happen.
|
|
||
| internal sealed class PaymentSelection : Parcelable { | ||
|
|
||
| var hasAcknowledgedSepaMandate: Boolean = false |
There was a problem hiding this comment.
Is this the right place to have sepa mandate check? Would it make sense to make this more generic? Maybe even nullable?
There was a problem hiding this comment.
Sepa is kinda like US Bank, very one off. I talked with Yuki about this too, while a generic solution seems reasonable, sepa is pretty unique in all of this.
This felt like the best place to put this when I was developing it, but if there's a better place, I'm more than happy to move it.
jameswoo-stripe
previously approved these changes
Oct 18, 2023
jameswoo-stripe
approved these changes
Oct 18, 2023
samer-stripe
approved these changes
Oct 18, 2023
|
I ran E2E tests locally to verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add saved payment method support for SEPA debit.
Motivation
https://docs.google.com/document/d/19RVShmZqOQDfShWY3731UBTTRP7INqQXqlAcmy4BY30/edit?pli=1#heading=h.htnywx28hw7v
stripe/stripe-ios#2908
Testing
Screenshots
Updated stripe bank icon:
Changelog