Saved SEPA support #2908
Merged
Saved SEPA support #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
force-pushed
the
yuki/saved-sepa-pms
branch
from
c6ef073 to
ce2aed4
Compare
yuki-stripe
force-pushed
the
yuki/saved-sepa-pms
branch
from
ce2aed4 to
e4781ea
Compare
3 tasks
yuki-stripe
force-pushed
the
yuki/saved-sepa-pms
branch
2 times, most recently
from
b497382 to
c31b278
Compare
…e continue button in saved options vc.
yuki-stripe
force-pushed
the
yuki/saved-sepa-pms
branch
from
b66f19c to
d4b77fc
Compare
eurias-stripe
suggested changes
Oct 18, 2023
Example/PaymentSheet Example/PaymentSheetUITest/PaymentSheetUITest.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheetFlowController.swift
Outdated
Show resolved
Hide resolved
...heet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentOptionsViewController.swift
Outdated
Show resolved
Hide resolved
...heet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentOptionsViewController.swift
Outdated
Show resolved
Hide resolved
...Sheet/StripePaymentSheet/Source/PaymentSheet/ViewControllers/SepaMandateViewController.swift
Show resolved
Hide resolved
...Sheet/StripePaymentSheet/Source/PaymentSheet/ViewControllers/SepaMandateViewController.swift
Outdated
Show resolved
Hide resolved
| @@ -19,6 +19,7 @@ class SimpleMandateTextView: UIView { | |||
| label.font = theme.fonts.caption | |||
| label.textColor = theme.colors.secondaryText | |||
| label.numberOfLines = 0 | |||
| label.textAlignment = .center | |||
There was a problem hiding this comment.
Does this affect other place where we are showing mandates?
There was a problem hiding this comment.
It does, I've asked JJ if that's what we want
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Views/TestModeView.swift
Show resolved
Hide resolved
eurias-stripe
previously approved these changes
Oct 18, 2023
...heet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentOptionsViewController.swift
Outdated
Show resolved
Hide resolved
...heet/Source/PaymentSheet/Saved Payment Method Screen/SavedPaymentOptionsViewController.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Views/TestModeView.swift
Show resolved
Hide resolved
eurias-stripe
previously approved these changes
Oct 18, 2023
eurias-stripe
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds saved SEPA PMs support.
Motivation
https://docs.google.com/document/d/19RVShmZqOQDfShWY3731UBTTRP7INqQXqlAcmy4BY30/edit?pli=1#heading=h.htnywx28hw7v
Testing
FlowController shows mandate if the customer hasn't seen it already:
Changelog
PaymentSheet
+* [Added] Saved SEPA payment methods are now displayed to the customer for reuse, similar to saved cards.