Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and android target version #6074

Merged
merged 6 commits into from
Jan 4, 2025
Merged

Conversation

westnordost
Copy link
Member

@westnordost westnordost commented Jan 2, 2025

most of the changes are because when targeting Android SDK level 35, all screens are edge-to-edge by default. so one needs to specify the insets manually.

It's quite complex to test this, as it may appear different for any combination of:

  • portrait or landscape mode (navigation is on the left or right side, but only if it is button navigation)
  • with display cutout (needs additional padding, can be located anywhere depending on display rotation)
  • right-to-left layout (expected location of the display cutout within the layout differs)
  • using gesture navigation vs using button-navigation (background of the navigation changes)
  • dark mode or light mode (color of the status bar icons changes)

E.g. when rotated to landscape mode, the display cutout will be on the left (or right) side, so there also needs to be a padding there.

But I think I tested it all. All screens are affected.

The visible changes are:

  • top bar has no background anymore (seems to be standard now in Android)
  • nav bar uses the default color now (background color almost-opaque when using navigation buttons, otherwise transparent)
  • main screen regards necessary padding for the display cutout (😕 which may look odd, sometimes, but we don't want that a button is below the display cutout)
  • you see some content below the navigation bar on scrollable screens (e.g. settings screen)
  • all the other screens other than the main screen also add a padding for the display cutout

@westnordost westnordost marked this pull request as ready for review January 3, 2025 13:10
app/build.gradle.kts Outdated Show resolved Hide resolved
Co-authored-by: Kai Michael Poppe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants