OsmNoteQuestController: surveyme override and regex test update #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves streetcomplete#6052. * Restructured exclusion of notes that get overridden by #surveyme * Added RegexOption.DOT_MATCHES_ALL to function NoteComment.containsSurveyRequiredMarker: #surveyme wasn't found at the end of the text added by the user, because SC add "\n\nvia StreetComplete <x.y>" to the text
FloEdelmann
reviewed
Jan 2, 2025
...c/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt
Outdated
Show resolved
Hide resolved
...c/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt
Show resolved
Hide resolved
|
@westnordost as Florian rightfully asked, I tried adding some tests for the changes I made and got a ton of errors hinting to the mockito-version being out of date. I changed those to the most recent (mockito-core and mockitor-android 5.14.2, mockito-inline is now merged into -core), which makes all tests work again for me. Is there any reason for not using the newest mockito packages? |
* containsSurveyRequiredMarker now also ignores case * added three tests
kmpoppe
changed the title
Simplify containsSurveryRequiredMarker
|
No, I think there wasn't a reason for the old version. Never bothered to upgrade because it was working fine and I didn't need any new features. |
|
Put the new version as a suggestion in your #6074. |
westnordost
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6052.