Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping controls with fast overlay switching #704

Open
rusty-snake opened this issue Dec 29, 2024 · 9 comments
Open

Overlapping controls with fast overlay switching #704

rusty-snake opened this issue Dec 29, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@rusty-snake
Copy link

screenshot

share_2475685121763125165

How to Reproduce

  • Enable fast overlay switching

Expected Behavior

No overlapping

Does it happen in normal StreetComplete?

No fast overlay switching avaiable

Versions affected

SCEE 60.0

@rusty-snake rusty-snake added the bug Something isn't working label Dec 29, 2024
@Helium314
Copy link
Owner

Doesn't happen on my phone for whatever reason.
I guess it's some issue with insets, similar to streetcomplete#6030

@mnalis
Copy link
Collaborator

mnalis commented Dec 30, 2024

Doesn't happen on my phone for whatever reason.

Works fine on my Android 14 (Samsung Galaxy S23+) and Android 10 (Huawei P30 Pro) too.

Can you share what Android version / device model are you using @rusty-snake ?

@mcliquid
Copy link

I can reproduce this behavior on my physical Android 15 (API 35) device and on the virtual Android 13 (API 33) machine.
The effect is not quite as pronounced in the emulator, but it is more noticeable on the physical device.
Virtual Device:
image

Physical Device:
image

Both are running on the latest Commit 9b95231 (freshly build from modified)

@rusty-snake
Copy link
Author

rusty-snake commented Dec 30, 2024

Can you share what Android version / device model are you using

  • GrapheneOS (AOSP 15 QPR 1)
  • Pixel 6

OK, played with developer option. Removing the display cut-out moves from it to the right position (although a bit spacing at the top wouldn't be wrong). So it looks like it is positioned relative to the screen rather then relative to the rest of the app.

I also noticed that on small hights (landscape or split screen), it overlaps the bottom buttons.

@Helium314
Copy link
Owner

So it looks like it is positioned relative to the screen rather then relative to the rest of the app.

Thanks, so I'd say it's definitely something very similar to streetcomplete#6030 ("usable" screen size vs physical screen size).

I also noticed that on small hights (landscape or split screen), it overlaps the bottom buttons.

This is a side effect on most of the UI being compose now, but the quick-switch still using the "normal" Android views. At some point I'll switch everything to compose, but that's a lot of work (at least initially for learning compose) and not priority.

@RubenKelevra
Copy link

I can confirm this bug with Android 12. Compared to v59 the list is now cut off much earlier, requiring scrolling and is positioned wrong, so it's not in line with the icon on top:

v60

Screenshot_2024-12-30-11-07-15-440-edit_de.westnordost.streetcomplete.expert.jpg

v59

Screenshot_2024-12-27-12-35-37-595-edit_de.westnordost.streetcomplete.expert.jpg

@mnalis
Copy link
Collaborator

mnalis commented Jan 7, 2025

I wonder if streetcomplete#6074 might've helped with that... We should see on the next release 🤷‍♂️

@rusty-snake
Copy link
Author

Still a problem in 60.1

@mnalis
Copy link
Collaborator

mnalis commented Jan 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants