Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define securityContext for components #1041

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Define securityContext for components #1041

merged 2 commits into from
Jun 20, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Jun 19, 2023

Motivation

  • Define securityContext for sla detector
  • Fix securityContext for alert manager

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from a team, sijie and addisonj as code owners June 19, 2023 09:28
@github-actions
Copy link

@ciiiii:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Jun 19, 2023
@github-actions
Copy link

@ciiiii:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 19, 2023
@ericsyh ericsyh added this to the sn-platform-1.10.4 milestone Jun 20, 2023
@ericsyh ericsyh requested a review from a team June 20, 2023 01:26
Copy link
Member

@tuteng tuteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need to update the sn-platform-slim chart?

@ciiiii ciiiii merged commit 673bd4b into master Jun 20, 2023
@ciiiii ciiiii deleted the yscai/security-context branch June 20, 2023 07:05
ciiiii added a commit that referenced this pull request Jun 20, 2023
ericsyh pushed a commit that referenced this pull request Jun 20, 2023
ericsyh pushed a commit that referenced this pull request Jun 21, 2023
* Sync #1041

* Sync #1042

* Fix helm syntax error

(cherry picked from commit 987dcc7)
ericsyh pushed a commit that referenced this pull request Jun 21, 2023
* Define securityContext for sla detector

* Fix securityContext for alert manager

(cherry picked from commit 673bd4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants