Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sn-platform-slim] Sync securityContext changes #1043

Merged
merged 3 commits into from
Jun 20, 2023
Merged

[sn-platform-slim] Sync securityContext changes #1043

merged 3 commits into from
Jun 20, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Jun 20, 2023

Motivation

sync PRs

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from a team, sijie and addisonj as code owners June 20, 2023 08:05
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 20, 2023
tuteng
tuteng previously approved these changes Jun 20, 2023
View reviewed changes
@ericsyh ericsyh added this to the sn-platform-1.10.4 milestone Jun 20, 2023
@ericsyh ericsyh merged commit 987dcc7 into master Jun 20, 2023
@ericsyh ericsyh deleted the yscai/slim branch June 20, 2023 13:50
ericsyh pushed a commit that referenced this pull request Jun 21, 2023
@ciiiii @ericsyh
[sn-platform-slim] Sync securityContext changes (#1043)
83863ee 
* Sync #1041

* Sync #1042

* Fix helm syntax error

(cherry picked from commit 987dcc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerbitx zerbitx zerbitx approved these changes

@tuteng tuteng tuteng left review comments

@sijie sijie Awaiting requested review from sijie

@addisonj addisonj Awaiting requested review from addisonj

Assignees

@ciiiii ciiiii

Labels
no-need-doc This pr does not need any document
Projects
None yet
Milestone
sn-platform-1.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ciiiii @zerbitx @tuteng @ericsyh