Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rootless busybox in toolset #1042

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Support rootless busybox in toolset #1042

merged 2 commits into from
Jun 20, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Jun 19, 2023

Motivation

Run toolset in rootless env

Modifications

  • Make busybox rootless
  • Add option installBusybox

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from a team, sijie and addisonj as code owners June 19, 2023 15:45
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 19, 2023
@ericsyh ericsyh added this to the sn-platform-1.10.4 milestone Jun 20, 2023
@ericsyh ericsyh requested a review from a team June 20, 2023 01:25
@ciiiii ciiiii merged commit 3935361 into master Jun 20, 2023
@ciiiii ciiiii deleted the yscai/rootless-busybox branch June 20, 2023 07:04
ciiiii added a commit that referenced this pull request Jun 20, 2023
ericsyh pushed a commit that referenced this pull request Jun 20, 2023
ericsyh pushed a commit that referenced this pull request Jun 21, 2023
* Sync #1041

* Sync #1042

* Fix helm syntax error

(cherry picked from commit 987dcc7)
ericsyh pushed a commit that referenced this pull request Jun 21, 2023
* Make busybox rootless

* Add option installBusybox

(cherry picked from commit 3935361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants