Extract imageSnapshots to a separate package #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
requested review from
danielduan,
Hypnosphi,
thomasbertet and
usulpro
as code owners
# Conflicts: # addons/storyshots/storyshots-core/package.json # examples/official-storybook/package.json
Codecov Report
@@ Coverage Diff @@
## master #3742 +/- ##
==========================================
+ Coverage 41.38% 92.5% +51.11%
==========================================
Files 459 6 -453
Lines 5094 40 -5054
Branches 857 2 -855
==========================================
- Hits 2108 37 -2071
+ Misses 2475 2 -2473
+ Partials 511 1 -510Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Jun 10, 2018
|
@igor-dv all good :) Sorry for not being really active these days. |
Yama-Tomo
added a commit
to Yama-Tomo/DefinitelyTyped
that referenced
this pull request
Jul 29, 2019
jessetrinity
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Aug 2, 2019
* refactor: remove separated package definition relate: storybookjs/storybook#3742 * feat: add new definition
iRON5
pushed a commit
to iRON5/DefinitelyTyped
that referenced
this pull request
Aug 13, 2019
…elyTyped#37207) * refactor: remove separated package definition relate: storybookjs/storybook#3742 * feat: add new definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3734, #3623
What I did
Refactored addon-storyshots to two pkgs:
Would like to have a discussion about the change here (C.C. @thomasbertet )
Maybe I will add some more refactoring here regarding to the #2517 (or in a separate PR).Update: ☝️ PRed here