Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Image snapshots with webdriverio for cross-browser visual regression testing #3734

Closed
alexparish opened this issue Jun 8, 2018 · 5 comments

Comments

@alexparish
Copy link

alexparish commented Jun 8, 2018

Image snapshots in Storyshots is a fantastic addition and I'd like to start by thanking the contributors for adding this important tool.

In the past I've found that having cross-browser visual regression tests is crucial because, as great as Puppeteer is, it's always the troublesome older browsers such as IE11 that experience regressions. Additionally, most of the engineers I know carry out their development in Chrome so would already spot any regressions that would be caught by Puppeteer while other browsers get forgotten.

This is why I am proposing adding support for webdriverio to image snapshots.

It should be possible to replace references to Puppeteer in test-body-image-snapshot.js with an interface that implements both Puppeteer and webdriverio. There will be some interesting challenges, such as comparing image snapshots for multiple browsers during a test run, but they shouldn't be insurmountable.

@alexparish alexparish changed the title Storyshots image snapshots with webdriverio for cross-browser regression testing Storyshots: image snapshots with webdriverio for cross-browser regression testing Jun 8, 2018
@alexparish alexparish changed the title Storyshots: image snapshots with webdriverio for cross-browser regression testing Storyshots: image snapshots with webdriverio for cross-browser visual regression testing Jun 8, 2018
@alexparish alexparish changed the title Storyshots: image snapshots with webdriverio for cross-browser visual regression testing Proposal: Image snapshots with webdriverio for cross-browser visual regression testing Jun 8, 2018
@danielduan
Copy link
Member

danielduan commented Jun 8, 2018

I think it's a great idea to screenshot across browsers. There's been discussions around splitting the storyshot addon into separate addons - snapshots, screenshots, etc.

If you're interested in helping, feel free to join our slack channel and discuss. @igor-dv thoughts?

@igor-dv
Copy link
Member

igor-dv commented Jun 11, 2018

@alexparish, your arguments sound reasonable, though I can't really advocate about having one or another 3rd party library support, since always will be people that will argue against =) I can just suggest adding both =) So you are welcome to contribute.

I've separated image snapshots out of the core storyshots api to the addon-storyshots-puppeteer package, You can add another one called addon-storyshots-webdriverio. It will be a cool addition to this addon.

@stale
Copy link

stale bot commented Jul 2, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 2, 2018
@stale
Copy link

stale bot commented Aug 1, 2018

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Aug 1, 2018
@okmttdhr
Copy link

okmttdhr commented Nov 3, 2020

This might help anyone who wants WebdriverIO addon;
https://github.com/andrcuns/addon-storyshots-wdio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants