-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storyshots addon refactoring #3745
Conversation
…the snapshot files + extract api to a separate dir structure
Codecov Report
@@ Coverage Diff @@
## master #3745 +/- ##
=========================================
+ Coverage 41.23% 41.53% +0.3%
=========================================
Files 459 461 +2
Lines 5100 5128 +28
Branches 860 860
=========================================
+ Hits 2103 2130 +27
- Misses 2482 2483 +1
Partials 515 515
Continue to review full report at Codecov.
|
LMK when it's ready for review |
I think it's ready. Will work on other stuff in smaller PRs. |
@@ -307,9 +307,32 @@ initStoryshots({ | |||
|
|||
Take a snapshot of a shallow-rendered version of the component. Note that this option will be overriden if you pass a `renderer` option. | |||
|
|||
### `getSnapshotFileName` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth mentioning in MIGRATION.md
, as well as puppeteer moving to other package
@Hypnosphi, can I merge this? |
Issue: including changed needed for #2517 (probably for #3152 too)
This PR is rebased on "storyshots-separation" branch because I didn't want to wait for the #3742 to be merged.
What I did
Stories2SnapsConverter
in order to map story-files to snapshot-files and vise versa.