-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.2 #1383
Merged
Merged
Release/3.2 #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for vue in addon-notes
# Conflicts: # examples/cra-kitchen-sink/.storybook/addons.js # examples/cra-kitchen-sink/package.json
Add warning when module is missing in storiesOf
danielduan
approved these changes
Jul 26, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The published alpha works well for me!
`withKnobs` the decorator is still the base API. (This now works for Vue). The new API is called `wrapperKnobs` and will eventually be merged into `withKnob` (c.f. medium term addons plan, to be posted)
Revert knobs API to previous API.
shilman
commented
Jul 27, 2017
lib/ui/package.json
Outdated
@@ -33,7 +33,7 @@ | |||
"react-komposer": "^2.0.0", | |||
"react-modal": "^1.7.7", | |||
"react-split-pane": "^0.1.63", | |||
"react-treebeard": "^2.0.3", | |||
"react-split-pane": "^0.1.65", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad merge??
Fix bad merge that removed react-treebeard dep from lib/ui
ndelangen
approved these changes
Jul 27, 2017
kazupon
approved these changes
Jul 27, 2017
…eadonly-prop-assign Quick-fix for story hierarchy UI and react16
This was referenced Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Placeholder for 3.2 release
How to test
TBD