Revert knobs API to previous API. #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`withKnobs` the decorator is still the base API. (This now works for Vue). The new API is called `wrapperKnobs` and will eventually be merged into `withKnob` (c.f. medium term addons plan, to be posted)
shilman
requested changes
Jul 27, 2017
There was a problem hiding this comment.
I love this. However, can we just NOT export wrapperKnobs for now since this is about not changing the API prematurely?
I'd like to implement the withX HOC proposal (or something like it) together and release it in 3.3.
Proposal: https://gist.github.com/shilman/792dc25550daa9c2bf37238f4ef7a398
|
I'm OK with removing it, although I suspect others may be keen to use knobs per-story? I'll remove it but we can revert if people object strongly. |
shilman
approved these changes
Jul 27, 2017
|
Ready to merge IMHO |
ndelangen
added
addon: info
addon: knobs
react
vue
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withKnobsthe decorator is still the base API. (This now works forVue).
The new API is called
wrapperKnobsand will eventually be merged intowithKnobs(c.f. medium term addons plan, to be posted)Counter proposal to #1524
The basic idea is to leave the knobs API unchanged for now.
withKnobsis still a decorator.We now export
wrapperKnobs(I'm open to changing this name, I'm not sureaddonKnobsreally says what it is though), which is a higher-order-component (HOC) wrapper API.Medium term plan is as follows:
Allow "wrapper" HOC functions to be used as decorators (this require core changes, maybe in 3.3) (see Allow decorator API to accept HOC-style wrappers #1528)
Transition
withKnobsto be a wrapper (iewithKnobs = wrapperKnobs).