-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.2 #1383
Merged
Merged
Release/3.2 #1383
Changes from 221 commits
Commits
Show all changes
240 commits
Select commit
Hold shift + click to select a range
c3b35e6
WIP
ndelangen fcd6283
WIP, webpack succesful
ndelangen 7b53666
testing
ndelangen b1470eb
Implement basic working version, Cannot handle extension and global c…
alexandrebodin 23aadf4
:shirt: refactor(client): update preview rendering
kazupon c23caa9
:shirt: refactor(examples): update stories
kazupon ccbbf6e
Publish alpha.0
ndelangen 55aa3ff
Make global examples work if config.js bootstrap components and exten…
alexandrebodin e7b9b0a
Make working examples for functions, Vue extensions and Vue global co…
alexandrebodin 6b21da8
fix dep for lerna bootstrap
alexandrebodin cc546c5
HMR works!
ndelangen d51f83e
CHANGE favicon
ndelangen 9454fa7
ADD example with actions and links
ndelangen d0dc873
Update the dep value to work with next releases of @storybook/vue
alexandrebodin 385611b
Merge branch 'master' into add-app-vue
ndelangen 9974a3b
Add support for vue in addon-notes
alexandrebodin bf00a9a
Make addon notes agnostic
alexandrebodin 514f4b7
deprecate old WithNotes but keep backward compatible
alexandrebodin 5a6472d
Cleaning up deps and comments
alexandrebodin a93eba3
Merge pull request #1278 from storybooks/addon-notes-vue
ndelangen b41fda4
:construction: wip: add story template for vue app project
kazupon ff56861
:up: update(cli): getstorybook vue supporting
kazupon 765d394
Merge branch 'master' into add-app-vue
ndelangen 9bd55bc
:up: update(cli): stories creating for vue
kazupon 82d44e8
Merge branch 'add-app-vue' into getstorybook-support-for-vue
kazupon 19dcfd9
Change docs to contains Vue info
ndelangen db319e4
Merge branch 'master' into add-app-vue
ndelangen d9a3da5
Make a working example
alexandrebodin 5e66224
Cleaning up
alexandrebodin aef1f01
less ugly working example
alexandrebodin 5784a79
Comment unused to make PR clear
alexandrebodin bac1905
Add support for addonKnobs, rename withX to addonX to avoid name coll…
alexandrebodin 6255569
Finish cleanup of addon knobs
alexandrebodin 4c1daab
More clean up
alexandrebodin 3e12ba1
:shirt: refactor: tweak style guide
kazupon b355060
Fix example using a function as a component to object component
alexandrebodin 4dd6b78
Make example a proper vue app
alexandrebodin 3260f7d
Readme fix
alexandrebodin 1e91907
Wording
alexandrebodin 838730f
:up: update: show the error at storybook/vue
kazupon 2e3170d
:pencil: docs: update vue guide
kazupon 040f4e0
Merge pull request #1287 from kazupon/getstorybook-support-for-vue
alexandrebodin 68d237c
Remove unwatend packe-lock.json
alexandrebodin bc84ee6
Rename vue example to vue-kitchen-sink
alexandrebodin 8145ac3
Merge branch 'master' into add-app-vue
alexandrebodin d3c53c1
:up: update: fix error display
kazupon 70a043f
add more examples with knobs fields
alexandrebodin 8178ec1
Merge branch 'add-app-vue' of github.com:storybooks/storybook into ad…
alexandrebodin 043b5f1
Merge branch 'master' into add-app-vue
ndelangen 5daa769
Merge branch 'master' into add-app-vue
alexandrebodin 6c95ac9
add tests
alexandrebodin 6e8f869
fix dependency
alexandrebodin c7efe5a
bumping version
alexandrebodin 654be24
bumping version
alexandrebodin e35aeee
Merge branch 'add-app-vue' of github.com:storybooks/storybook into ad…
alexandrebodin 7be65d4
fix resolve in webpack
alexandrebodin a7a3900
Add left panel hierarchy support
ad32ffa
Fix a few related codebeat issues
6960d91
Add more tests for stories.js
3dbdb9e
Better UI for the hierarchy view + bugs fixes
6bfed5d
Merge remote-tracking branch 'origin/master' into left-panel-hierarchy
56f96a6
remove typings for @storybook/addon-knobs, references https://github.…
joscha e9a2ec8
remove typings for @storybook/addon-links, references https://github.…
joscha 64e9c1e
remove typings for @storybook/addon-options, references https://githu…
joscha f4b3df3
remove typings for @storybook/addon-notes, references https://github.…
joscha dcae32f
Merge branch 'master' into joscha/remove-addon-knobs-types
joscha f27825d
Add shortcut to toggle hierarchy
9b00eb3
Extract hierarchy creation to the mapper
igor-dv 96031cd
Merge branch 'master' into add-app-vue
ndelangen e87bcf5
Merge branch 'master' into release/3.2
shilman d806c3f
WIP
ndelangen d41655a
Merge branch 'master' of github.com:storybooks/storybook into add-app…
alexandrebodin c7ddd09
clean up build and wording
alexandrebodin f2926f4
bump to alpha 4
alexandrebodin 06a4c54
Remove shortcuts for the hierarchy toggling + change leftPanelHierarc…
igor-dv c16cc2d
Rename resolveStoryHierarchyNamespace to resolveStoryHierarchy
igor-dv cafa395
FIX multiple version react in vue app
ndelangen 0605107
CLEANUP
ndelangen 3fde529
Fix tests + Add tests for hierarchy
igor-dv 997f3d9
FIX multiple versions of react & vue && CLEANUP
ndelangen 5e82586
Merge pull request #1342 from joscha/joscha/remove-addon-links-types
shilman 11dc35d
Merge pull request #1339 from joscha/joscha/remove-addon-knobs-types
shilman a88354c
Merge pull request #1343 from joscha/joscha/remove-addon-options-types
shilman f2241b4
Merge pull request #1344 from joscha/joscha/remove-addon-notes-types
shilman 17fb4f5
Fix the cases when the separator is not a "."
igor-dv 87adce4
Add assertions to left_panel.test.js
igor-dv bbf6360
Fix warnings in stories.test.js
igor-dv 1c33fda
Fix tests + Add tests
igor-dv df26718
Remove require.resolve from libs/ui webpack.config.js
igor-dv 21d7173
Remove package-lock.json files
igor-dv f57a602
Merge pull request #1329 from igor-dv/left-panel-hierarchy
shilman b4e794d
Try to use react-treebeard
igor-dv 1472ae9
Try to save local state of the nodes inside the stories.js
igor-dv 4e7037f
Alow animations (with warnings) + Styling
igor-dv dbb04c1
Repalce resolveStoryHierarchy func with hierarchySeparator
igor-dv 142b2b8
Merge remote-tracking branch 'origin/151-story-hierarchy' into story-…
igor-dv 17fb92f
Delete unused code + adjust names
igor-dv 8f1a4d6
Fix hierarchy + remove unused functionality
igor-dv ec67cc5
:up: update(server): tweak consoleoutputing
kazupon a024975
Fix stories.test.js
igor-dv c25ac5b
Update global hook for Vue Devtools
matt-oconnell 3f76d6c
Remove the root node of the tree
igor-dv 8a98f62
Add react-icons for a better tree structure
igor-dv 279e198
Change the order of the atomic namespace
igor-dv 74fde7b
Merge branch 'master' into release/3.2
shilman 43ca59b
Merge remote-tracking branch 'origin/release/3.2' into 151-story-hier…
igor-dv 8262b7b
Revert code that was injected by aliens
igor-dv 2fdf710
Merge remote-tracking branch 'origin/151-story-hierarchy' into story-…
igor-dv 0362bc2
Merge pull request #1356 from storybooks/151-story-hierarchy
igor-dv fa4ee72
Remove a redundant comment
igor-dv 4c562c3
Move decorators to separate file
igor-dv 836215f
Fix a bug when the component node and one of the namespaces nodes hav…
igor-dv 2980693
Extract tree_style to separate file
igor-dv d2f259b
Merge branch 'add-app-vue' of github.com:storybooks/storybook into ad…
alexandrebodin 929eb38
Merge branch 'master' of github.com:storybooks/storybook into add-app…
alexandrebodin 864e97e
fix version in package.json
alexandrebodin 3e315bb
Use a forked version of the react-treebeard
igor-dv 80f7ab2
Merge branch 'master' into release/3.2
shilman 682d394
Merge branch 'release/3.2' into 151-story-hierarchy
shilman a10d19d
Merge remote-tracking branch 'origin/151-story-hierarchy' into 151-st…
shilman 83bb874
Merge branch 'release/3.2' into add-app-vue
shilman 5a6ca6c
Rename stories dir to the stories_tree to prevent prepublish script i…
igor-dv cf94190
Merge pull request #1267 from storybooks/add-app-vue
shilman 3d65aad
Upgrade storybook-react-treebeard to a newer version that fixes impor…
igor-dv f048d32
Add more tests for stories_tree
igor-dv b26e39b
Merge pull request #1387 from storybooks/151-story-hierarchy
shilman 5642b7d
v3.2.0-alpha.5
shilman c0eb57a
Update cra-kitchen-sink versioning for alpha release
shilman 90e9780
Fix typo
shilman 61f6878
Fix loss of the state in a reall app with componentWillReceiveProps
igor-dv a2802e5
Merge pull request #1400 from storybooks/examples-3.2-alpha-versioning
shilman 957ff8f
Merge branch 'release/3.2' into 151-story-hierarchy
shilman 281b021
Add tests to check the componentWillReceiveProps
igor-dv 0e06e1a
Merge remote-tracking branch 'origin/release/3.2' into 151-story-hier…
igor-dv 03e10d0
Bump vue to 3.2.0-alpha.6 to publish as latest (getstorybook needs this)
alexandrebodin fe3f19d
Use deepEqual to compare selectedHierarchy
igor-dv 9120949
Merge remote-tracking branch 'origin/release/3.2' into 151-story-hier…
igor-dv 3096cde
Merge remote-tracking branch 'origin/151-story-hierarchy' into 151-st…
shilman d6177f8
Merge pull request #1401 from storybooks/151-story-hierarchy
shilman 3d1926b
Merge pull request #1419 from storybooks/master
shilman e50d7b2
Merge branch 'release/3.2' into update-global-hook
ndelangen f6e4c11
v3.2.0-alpha.7
shilman fbc665f
v3.2.0-alpha.7
shilman e34cf19
Add keyboard accessibility to stories tree
igor-dv 392f4d4
Merge branch '151-story-hierarchy' of https://github.com/storybooks/s…
igor-dv 3607ed5
Merge remote-tracking branch 'origin/release/3.2' into 151-story-hier…
igor-dv 86679eb
MVP version of the on device React Native UI
matt-oakes 760a752
Fix long story name word-breaking
igor-dv de858e5
Add test for pressing enter on story
igor-dv c390802
Implement filtering on story-level
jackhurley23 a1a0d14
Update filtering to be case-insensitive at story level
jackhurley23 c331251
Update cra-kitchen-sink package versions for 3.2-alpha
shilman f2054b9
Merge pull request #1434 from storybooks/1433-fix-alpha-versions
ndelangen d9a2948
Refactoring Addon Info [WIP]
usulpro d41888f
Addons composition
usulpro d214b7e
Merge remote-tracking branch 'origin/release/3.2' into 151-story-hier…
igor-dv 28eb25a
Add hierarchySeparator to README
joscha 0c9d561
Fix addon notes
usulpro 73f64c8
Add withInfo()(storyFn)
usulpro 6481449
Fix the left panel width when narrowing
igor-dv e13d727
Merge pull request #1448 from storybooks/Fix-addon-notes
usulpro 7e9c35d
Merge branch 'release/3.2' into joscha/add-hierarchySeparator
ndelangen e0422ff
Merge remote-tracking branch 'origin/release/3.2' into 151-story-hier…
igor-dv 973e8ea
Merge branch 'release/3.2' into 1147-info-addon
usulpro ec8ee5c
Add deprecation warning
usulpro 0e8230c
Refactoring withInfo function
usulpro 868dced
Add test
usulpro 1e2892f
Improve test coverage
usulpro 6c128f3
Fix typo
usulpro 3832ae9
Switch to util-deprecate
usulpro cabfee0
Mark the nested prop types with isRequired
igor-dv a73d01d
Fix tests and default props
usulpro d6efd70
Merge pull request #1452 from storybooks/1147-info-addon
shilman a22cdda
Merge branch 'release/3.2' into 151-story-hierarchy
shilman 0121a7c
Merge pull request #1427 from storybooks/151-story-hierarchy
igor-dv 594dab4
Merge branch 'release/3.2' into joscha/add-hierarchySeparator
ndelangen fdcacc8
cahnge to /
joscha 1c59065
Merge branch 'master' into release/3.2
shilman 560224c
Merge pull request #1445 from storybooks/joscha/add-hierarchySeparator
shilman 65e7341
Merge pull request #1432 from jhurley23/109-story-level-filtering
shilman ed8bbcb
:pushpin: dependency(vue): bump vue
kazupon 7f5dd72
:shirt: refactor(vue): tweak vue implementation
kazupon 573f986
:pushpin: dependency(examples): bump dependency modules
kazupon 45ada35
Merge branch 'release/3.2' into update-global-hook
ndelangen 0958ab5
Set '/' as a default hierarchySeparator
igor-dv 88be449
Remove '/' from ui\example\client\provider since it's a default value
igor-dv 48ee2cd
Change the react-treebeard to the main repo version
igor-dv 3c84722
Merge branch 'release/3.2' into storybook-native-ui
ndelangen 889ea2b
Change toggle icon and delete other icons to make the tree look clean…
igor-dv 7c717ae
Merge pull request #1413 from matt-oakes/storybook-native-ui
shilman 64c053f
Merge branch 'release/3.2' into 151-story-hierarchy
ndelangen 91b62f0
Merge branch 'release/3.2' into tweak/vue-app
ndelangen 874a780
Merge pull request #1488 from storybooks/151-story-hierarchy
igor-dv 3862c99
Merge branch 'master' into release/3.2
ndelangen 1d09d47
linting
ndelangen 0968770
UPDATE / SYNC package dependencies for optimal bootstrap
ndelangen 852ee89
FIX sometimes storyName being undefined when url is '/'
ndelangen 312eebf
Merge branch 'release/3.2' into tweak/vue-app
ndelangen d9ff515
:pushpin: dependecy:make vue-template-compiler the same as vue core
kazupon 0daec90
Merge pull request #1477 from kazupon/tweak/vue-app
shilman 4513cc9
v3.2.0-alpha.8
shilman 9fe1a14
Fix vue release and examples dependencies
shilman c00f4d5
Merge branch 'master' into release/3.2
ndelangen 2513f6e
Extract nopreview component & allow it to be re-rendered
ndelangen 1e696e9
Fix a 'funny' hmr issue
igor-dv bf2e4ee
FIX unittests
ndelangen 1a671ec
Merge branch 'release/3.2' into fix-nopreview-vue
ndelangen 07ece8e
Merge branch 'release/3.2' into fix-hmr-issue-in-cra-kitchen-sink
ndelangen 958e5d8
Merge pull request #1504 from storybooks/fix-nopreview-vue
ndelangen 52adbc3
Merge branch 'release/3.2' into fix-hmr-issue-in-cra-kitchen-sink
ndelangen 5b30336
Merge pull request #1508 from storybooks/fix-hmr-issue-in-cra-kitchen…
ndelangen a0a8ab3
Fix RN preview welcome instructions
shilman 0f8755c
Reset storybook on startup?
shilman 8f8f55e
Show first story on OnDeviceUI startup
shilman a9b1664
Merge branch 'release/3.2' into 1492-on-device-startup
shilman ecd054d
Merge branch 'release/3.2' into update-global-hook
ndelangen afacba9
Merge pull request #1376 from matt-oconnell/update-global-hook
ndelangen f26700d
Update README.md
ndelangen dfaaa09
Merge pull request #1510 from storybooks/1492-on-device-startup
shilman 0f3b878
v3.2.0-alpha.9
shilman 73130d4
Merge branch 'master' into release/3.2
ndelangen b7f43ed
Merge branch 'master' into release/3.2
ndelangen 63404f6
Merge branch 'master' into release/3.2
ndelangen de75c5d
Merge branch 'master' into release/3.2
ndelangen d6f1b89
Add warnings if 'module' is missing
igor-dv 949f62f
Merge pull request #1525 from storybooks/hmr-warning-on-storiesOf
igor-dv 21e4081
Merge branch 'master' into release/3.2
ndelangen 6f74da4
Revert knobs API to previous API.
tmeasday 5e9d574
Remove wrapperKnobs
tmeasday ea02ddd
Revert addonNotes -> withNotes
tmeasday dcb3e1f
Merge pull request #1527 from storybooks/simplifyKnobsAPI
shilman 6b8a1b8
Fix bad merge that removed react-treebeard dep from lib/ui
shilman 5ba0e4f
SYNC dependencies for improved hoisting
ndelangen 79a8896
Merge pull request #1531 from storybooks/fix-3.2-package-versions
shilman 0188ace
v3.2.0-alpha.10
shilman 1b25491
Add negative margin to move the tree to the left =/
igor-dv b8bcabe
Merge pull request #1533 from storybooks/1532-fix-stories-decorator-r…
shilman 64d2976
v3.2.0-alpha.11
shilman f8ce75f
Update example package deps
shilman 570e3e8
v3.2.0 changelog
shilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ node_modules | |
app/**/demo/** | ||
docs/public | ||
|
||
vue | ||
|
||
*.bundle.js | ||
*.js.map | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "@storybook/addon-centered", | ||
"version": "3.1.9", | ||
"version": "3.2.0-alpha.8", | ||
"description": "Storybook decorator to center components", | ||
"license": "MIT", | ||
"author": "Muhammed Thanish <[email protected]>", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* global document */ | ||
|
||
import React from 'react'; | ||
import ReactDOM from 'react-dom'; | ||
import AddonInfo, { withInfo, setDefaults, addInfo } from './'; | ||
|
||
/* eslint-disable */ | ||
const TestComponent = ({ func, obj, array, number, string, bool, empty }) => | ||
<div> | ||
<h1>{func}</h1> | ||
<h2>{obj.toString()}</h2> | ||
<h3>{array}</h3> | ||
<h4>{number}</h4> | ||
<h5>{string}</h5> | ||
<h6>{bool}</h6> | ||
<p>{empty}</p> | ||
<a href="#">test</a> | ||
<code>storiesOf</code> | ||
<ui> | ||
<li>1</li> | ||
<li>2</li> | ||
</ui> | ||
</div>; | ||
/* eslint-enable */ | ||
|
||
const testContext = { kind: 'addon_info', story: 'jest_test' }; | ||
const testOptions = { propTables: false }; | ||
|
||
describe('addon Info', () => { | ||
const story = context => | ||
<div> | ||
It's a {context.story} story: | ||
<TestComponent | ||
func={x => x + 1} | ||
obj={{ a: 'a', b: 'b' }} | ||
array={[1, 2, 3]} | ||
number={7} | ||
string={'seven'} | ||
bool | ||
/> | ||
</div>; | ||
const api = { | ||
add: (name, fn) => fn(testContext), | ||
}; | ||
it('should render <Info /> and markdown', () => { | ||
const Info = withInfo( | ||
'# Test story \n## with markdown info \ncontaing **bold**, *cursive* text and `code`' | ||
)(story); | ||
ReactDOM.render(<Info />, document.createElement('div')); | ||
}); | ||
it('should render with missed info', () => { | ||
setDefaults(testOptions); | ||
addInfo(null, testContext, story, testOptions); | ||
}); | ||
it('should show deprecation warning', () => { | ||
const addWithInfo = AddonInfo.addWithInfo.bind(api); | ||
addWithInfo('jest', story); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
{ | ||
"name": "@storybook/addon-knobs", | ||
"version": "3.1.9", | ||
"version": "3.2.0-alpha.8", | ||
"description": "Storybook Addon Prop Editor Component", | ||
"license": "MIT", | ||
"main": "dist/index.js", | ||
"typings": "./storybook-addon-knobs.d.ts", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/storybooks/storybook.git" | ||
|
@@ -16,7 +15,7 @@ | |
"storybook": "start-storybook -p 9010" | ||
}, | ||
"dependencies": { | ||
"@storybook/addons": "^3.1.6", | ||
"@storybook/addons": "^3.2.0-alpha.8", | ||
"babel-runtime": "^6.23.0", | ||
"deep-equal": "^1.0.1", | ||
"global": "^4.3.2", | ||
|
@@ -26,7 +25,8 @@ | |
"prop-types": "^15.5.10", | ||
"react-color": "^2.11.4", | ||
"react-datetime": "^2.8.10", | ||
"react-textarea-autosize": "^4.3.0" | ||
"react-textarea-autosize": "^4.3.0", | ||
"util-deprecate": "^1.0.2" | ||
}, | ||
"devDependencies": { | ||
"@types/node": "^7.0.12", | ||
|
@@ -37,7 +37,8 @@ | |
"react-dom": "^15.5.4", | ||
"style-loader": "^0.17.0", | ||
"typescript": "^2.2.2", | ||
"typescript-definition-tester": "^0.0.5" | ||
"typescript-definition-tester": "^0.0.5", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we still need this, now that we have moved the typescript definitions?
|
||
"vue": "^2.4.1" | ||
}, | ||
"peerDependencies": { | ||
"react": "*", | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.