Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Distribute both ESM and CJS modules #13013

Merged
merged 36 commits into from
Dec 15, 2020
Merged

Perf: Distribute both ESM and CJS modules #13013

merged 36 commits into from
Dec 15, 2020

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 4, 2020 •
edited
Loading

  • Add a extra compile step to the prepare script for each package, this generates dist/cjs + dist/esm
  • Packages that must be compiled by TS to work get ignored
  • Moved types output to dist dist/ts3.9 + dist/ts3.4

@ndelangen ndelangen self-assigned this Nov 4, 2020
@ndelangen ndelangen added maintenance User-facing maintenance tasks performance issue labels Nov 4, 2020
@shilman
Merge pull request #13424 from storybookjs/perf/react-hotkeys
a6e3ea6 
Perf: Replace react-hotkeys with useEffect keybinding
@ndelangen ndelangen mentioned this pull request Dec 11, 2020
Closed
@shilman
Copy link
Member

shilman commented Dec 14, 2020

Build failures:

ERR! src/stories/Button.stories.js
ERR!   Line 5:1:  Assign object to a variable before exporting as module default  import/no-anonymous-default-export
ERR! 
ERR! src/stories/Header.stories.js
ERR!   Line 5:1:  Assign object to a variable before exporting as module default  import/no-anonymous-default-export
ERR! 
ERR! src/stories/Page.stories.js
ERR!   Line 6:1:  Assign object to a variable before exporting as module default  import/no-anonymous-default-export

@shilman shilman added the run e2e extended test suite Run the e2e extended test suite in CircleCI workflows label Dec 15, 2020
@shilman shilman changed the title Perf: Build ESM dist Perf: Distribute both ESM and CJS modules Dec 15, 2020
@shilman shilman merged commit c61b404 into next Dec 15, 2020
@shilman shilman deleted the perf/esm-dist branch December 15, 2020 12:44
@shilman shilman mentioned this pull request Dec 16, 2020
Merged
3 tasks
@yannbf yannbf mentioned this pull request Dec 27, 2020
Merged
@shilman shilman mentioned this pull request Apr 29, 2021
Closed
@shriuken shriuken mentioned this pull request May 7, 2021
Closed
2 tasks
@IanVS IanVS mentioned this pull request Jun 3, 2021
Closed
@TristanWatanabe TristanWatanabe mentioned this pull request Jun 28, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanmaisse gaetanmaisse gaetanmaisse requested changes

@shilman shilman shilman left review comments

@hipstersmoothie hipstersmoothie Awaiting requested review from hipstersmoothie

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@shilman shilman

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks performance issue run e2e extended test suite Run the e2e extended test suite in CircleCI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ndelangen @hipstersmoothie @gaetanmaisse @tooppaaa @mrmckeb @shilman @tmeasday @ghengeveld