Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: Distribute both ESM and CJS modules #13013
Perf: Distribute both ESM and CJS modules #13013
Changes from all commits
04acc44
80b5af3
ff68aa2
9dedc4b
165ce2d
ab7d1b0
b28d812
5c65134
7e89b3e
6638cdb
2c7c510
6f1e16d
11d23c7
0c8dfcc
aab422d
53b13ad
380074c
e717ab1
6bff1ea
0930e4d
5f1ef64
5afd43a
84a4bde
6338b8b
95b3ec0
ca916ed
8fbf8db
d0617fa
e7f80e6
9399648
a6e3ea6
bf0bb28
5ca9ee5
799b34c
4a1987c
010938f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's done for other addons,
addons/backgrounds/src/preset/index.ts
can be deleted I guess?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this one isn't a
module.exports
anymore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm good question, don't think this is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hipstersmoothie WDYT? should this be cjs?