Switch Soroban tests to always use closeLedger to apply txs. #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
force-pushed
the
soroban_tests_bldb
branch
2 times, most recently
from
253ffd5
to
37b5303
Compare
dmkozh
changed the title
SirTyson
reviewed
Sep 6, 2024
6 tasks
SirTyson
approved these changes
Sep 10, 2024
This is a necessary change for the BucketListDB support. I've also changed a single test ('basic contract invocation') to only use in-memory LTX in order to cover lower-level logic.
dmkozh
force-pushed
the
soroban_tests_bldb
branch
from
c64a8a5
to
a28d840
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 14, 2024
# Description Resolves #4433 This switches the default testing backend to BucketListDB. While some test still disable BucketListDB and commit directly via `LedgerTxn` to test lower level subsystem, such as operation application, the majority of tests and all end-to-end tests no use BucketListDB. This is rebased on top of #4455. # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [x] Rebased on top of master (no merge commits) - [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [x] Compiles - [x] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4451
Switch Soroban tests to always use closeLedger to apply txs.
This is a necessary change for the BucketListDB support as it doesn't materialize changes on LTX commit. I've also changed a single test ('basic contract invocation') to only use in-memory LTX in order to cover lower-level logic.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)