Soroban tests need to work with closeLedger
#4451
Assignees
Labels
Comments
This was referenced Sep 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 10, 2024
# Description Resolves #4451 Switch Soroban tests to always use closeLedger to apply txs. This is a necessary change for the BucketListDB support as it doesn't materialize changes on LTX commit. I've also changed a single test ('basic contract invocation') to only use in-memory LTX in order to cover lower-level logic. # Checklist - [ ] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [ ] Rebased on top of master (no merge commits) - [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [ ] Compiles - [ ] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently almost all the Soroban tests rely on directly committing LTXs, which will no longer work with BucketListDB. There is currently a 'workaround' that just closes the ledger, but skips the tx result and tx meta and both are necessary for Soroban tests to function properly. Thus before we can disable SQL DB for the Soroban tests, we have to populate all the necessary data and fix all the tests that break due to using
closeLedger(some of the tests also rely on the ledger sequence not being bumped between applied transactions).The text was updated successfully, but these errors were encountered: