Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BucketListDB test coverage #4433

Closed
2 tasks done
marta-lokhova opened this issue Aug 20, 2024 · 0 comments · Fixed by #4462
Closed
2 tasks done

BucketListDB test coverage #4433

marta-lokhova opened this issue Aug 20, 2024 · 0 comments · Fixed by #4462
Assignees
@SirTyson
Labels
bug

Comments

@marta-lokhova
Copy link
Contributor

marta-lokhova commented Aug 20, 2024 •
edited
Loading

  • do an audit of the test suite, identify any other tests where coverage is missing (there are more, e.g. upgrades)
  • leave tests that don’t need buckets but need in-memory ledger txn as-is, explicitly enable SQL on them such that in tests.cpp we can still enable BL DB.

The goal of this issue is to remove DEPRECATED_SQL_LEDGER_STATE=true from test.cpp
@marta-lokhova marta-lokhova mentioned this issue Aug 29, 2024
Merged
6 tasks
@SirTyson SirTyson self-assigned this Sep 5, 2024
@anupsdf anupsdf mentioned this issue Sep 5, 2024
Closed
@SirTyson SirTyson mentioned this issue Sep 9, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 14, 2024
@marta-lokhova
Change default test backend to BucketListDB (#4462)
5f9cdc8 
# Description

Resolves #4433

This switches the default testing backend to BucketListDB. While some
test still disable BucketListDB and commit directly via `LedgerTxn` to
test lower level subsystem, such as operation application, the majority
of tests and all end-to-end tests no use BucketListDB. This is rebased
on top of #4455.

# Checklist
- [x] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [x] Rebased on top of master (no merge commits)
- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [x] Compiles
- [x] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirTyson SirTyson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change default test backend to BucketListDB SirTyson/stellar-core
2 participants
@marta-lokhova @SirTyson