Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild/change_trust: change trust bug fix #1298

Closed

Conversation

adirutwn
Copy link

If you're making a doc PR or something tiny where the below is irrelevant, just delete this
template and use a short description.

PR Structure

  • [✅] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • [✅ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • [✅ ] This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot

Thoroughness

  • [✅ ] This PR adds tests for the most critical parts of the new functionality or fixes.

Summary

Make the BuildXDR() in txnbuild/change_trust return correct operation

Summary of changes

Change the return variable from xdr.Operation{Body: Body} to op

What shouldn't be reviewed

Unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant