Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Txnbuild: fix bug in change trust operation #1299

Merged
merged 1 commit into from
May 16, 2019
Merged

Txnbuild: fix bug in change trust operation #1299

merged 1 commit into from
May 16, 2019

Conversation

poliha
Copy link
Contributor

@poliha poliha commented May 16, 2019

This PR fixes a bug in change trust operation which does not set the source account on the operation building the build process.
Closes #1298

@poliha poliha added the txnbuild 2nd-generation transaction build library for Go SDK label May 16, 2019
@poliha poliha added this to the txnbuild v1.2.0 milestone May 16, 2019
@poliha poliha requested a review from ire-and-curses May 16, 2019 18:38
ire-and-curses
ire-and-curses approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@poliha poliha merged commit 637edc2 into release-horizonclient-v1.2.0 May 16, 2019
@poliha poliha deleted the txnbuild-bugfix branch May 16, 2019 18:43
@ire-and-curses ire-and-curses mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ire-and-curses ire-and-curses ire-and-curses approved these changes

Assignees
No one assigned
Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poliha @ire-and-curses