txnbuild/change_trust: change trust bug fix

txnbuild/change_trust.go

@@ -49,5 +49,5 @@ func (ct *ChangeTrust) BuildXDR() (xdr.Operation, error) {
 	}
 	op := xdr.Operation{Body: body}
 	SetOpSourceAccount(&op, ct.SourceAccount)
-	return xdr.Operation{Body: body}, nil
+	return op, nil
 }

txnbuild/change_trust_test.go

@@ -0,0 +1,77 @@
+package txnbuild
+
+import (
+	"github.com/stellar/go/network"
+	"github.com/stellar/go/protocols/horizon"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestChangeTrust_BuildXDR(t *testing.T) {
+	t.Run("change trust source account is defined", func(t *testing.T) {
+		kp0 := newKeypair0()
+		txSourceAccount := horizon.Account{
+			HistoryAccount: horizon.HistoryAccount{
+				AccountID: kp0.Address(),
+			},
+			Sequence: "1",
+		}
+
+		kp1 := newKeypair1()
+
+		changeTrustOp := ChangeTrust{
+			Line: CreditAsset{
+				Code:   "ABC",
+				Issuer: kp0.Address(),
+			},
+			Limit: "100",
+			SourceAccount: &horizon.Account{
+				HistoryAccount: horizon.HistoryAccount{
+					AccountID: kp1.Address(),
+				},
+			},
+		}
+
+		tx := Transaction{
+			SourceAccount: &txSourceAccount,
+			Operations:    []Operation{&changeTrustOp},
+			Timebounds:    NewInfiniteTimeout(),
+			Network:       network.TestNetworkPassphrase,
+		}
+		received := buildSignEncode(t, tx, kp0, kp1)
+
+		// ref: https://www.stellar.org/laboratory/#xdr-viewer?input=AAAAAODcbeFyXKxmUWK1L6znNbKKIkPkHRJNbLktcKPqLnLFAAAAZAAAAAAAAAACAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAEAAAAAJcrx2g%2FHbs%2FohF5CVFG7B5JJSJR%2BOqDKzDGK7dKHZH4AAAAGAAAAAUFCQwAAAAAA4Nxt4XJcrGZRYrUvrOc1sooiQ%2BQdEk1suS1wo%2BoucsUAAAAAO5rKAAAAAAAAAAAC6i5yxQAAAEDXbTvlrszCXSWWcAqTRguDu85r0DQTdb3v9G5WyJScjmQk0CGUGTpBV%2BcDntgXIL24MIHa%2FOUCmVkpLOdTHGgO0odkfgAAAEDCof5Mzix5bBMArg%2BiZ5fpUohvUvXrBW%2BYH74p7qOFeMlf9SElUKY86ZsL6iwD7wZ9pIwECcxq6YSKxeI6ckUG&type=TransactionEnvelope&network=test
+		expectedXdr := "AAAAAODcbeFyXKxmUWK1L6znNbKKIkPkHRJNbLktcKPqLnLFAAAAZAAAAAAAAAACAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAEAAAAAJcrx2g/Hbs/ohF5CVFG7B5JJSJR+OqDKzDGK7dKHZH4AAAAGAAAAAUFCQwAAAAAA4Nxt4XJcrGZRYrUvrOc1sooiQ+QdEk1suS1wo+oucsUAAAAAO5rKAAAAAAAAAAAC6i5yxQAAAEDXbTvlrszCXSWWcAqTRguDu85r0DQTdb3v9G5WyJScjmQk0CGUGTpBV+cDntgXIL24MIHa/OUCmVkpLOdTHGgO0odkfgAAAEDCof5Mzix5bBMArg+iZ5fpUohvUvXrBW+YH74p7qOFeMlf9SElUKY86ZsL6iwD7wZ9pIwECcxq6YSKxeI6ckUG"
+		assert.Equal(t, expectedXdr, received, "Base 64 XDR should match")
+	})
+
+	t.Run("change trust source account is empty", func(t *testing.T) {
+		kp0 := newKeypair0()
+		txSourceAccount := horizon.Account{
+			HistoryAccount: horizon.HistoryAccount{
+				AccountID: kp0.Address(),
+			},
+			Sequence: "1",
+		}
+
+		changeTrustOp := ChangeTrust{
+			Line: CreditAsset{
+				Code:   "ABC",
+				Issuer: kp0.Address(),
+			},
+			Limit: "100",
+		}
+
+		tx := Transaction{
+			SourceAccount: &txSourceAccount,
+			Operations:    []Operation{&changeTrustOp},
+			Timebounds:    NewInfiniteTimeout(),
+			Network:       network.TestNetworkPassphrase,
+		}
+		received := buildSignEncode(t, tx, kp0)
+
+		// ref: AAAAAODcbeFyXKxmUWK1L6znNbKKIkPkHRJNbLktcKPqLnLFAAAAZAAAAAAAAAACAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAGAAAAAUFCQwAAAAAA4Nxt4XJcrGZRYrUvrOc1sooiQ
+		expectedXdr := "AAAAAODcbeFyXKxmUWK1L6znNbKKIkPkHRJNbLktcKPqLnLFAAAAZAAAAAAAAAACAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAGAAAAAUFCQwAAAAAA4Nxt4XJcrGZRYrUvrOc1sooiQ+QdEk1suS1wo+oucsUAAAAAO5rKAAAAAAAAAAAB6i5yxQAAAEC4Ukr2r6E1MdZoAqR8MA/5mSCbUWlsaaUOY6QZ7UB6EA3TsesoTGz2g20tepWo09knomr+EJFH+sgeFLrVE9MJ"
+		assert.Equal(t, expectedXdr, received, "Base 64 XDR should match")
+	})
+}

txnbuild/signers_test.go

@@ -102,7 +102,7 @@ func TestChangeTrustMultSigners(t *testing.T) {
 		Network:       network.TestNetworkPassphrase,
 	}
 	received := buildSignEncode(t, tx, kp0, kp1)
-	expected := "AAAAAODcbeFyXKxmUWK1L6znNbKKIkPkHRJNbLktcKPqLnLFAAAAZAAiII0AAAAbAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAGAAAAAUFCQ0QAAAAA4Nxt4XJcrGZRYrUvrOc1sooiQ+QdEk1suS1wo+oucsUAAAAABfXhAAAAAAAAAAAC6i5yxQAAAEBGh9ocFFyY4gH19pd+mVn6cUbOxlp6K4e3zNHfYd/WJ22nqpD89FBDa+iuSQGGpeqEGWELdiMqY6lYWsN2sisD0odkfgAAAEDXG99N0TmrMCyg7OixF0COempqsfraKGbRnQBtYHeH4ZauJzm81kshSRnHGenlrWM0KzMtevfeLGBFnA1Y/s4I"
+	expected := "AAAAAODcbeFyXKxmUWK1L6znNbKKIkPkHRJNbLktcKPqLnLFAAAAZAAiII0AAAAbAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAEAAAAAJcrx2g/Hbs/ohF5CVFG7B5JJSJR+OqDKzDGK7dKHZH4AAAAGAAAAAUFCQ0QAAAAA4Nxt4XJcrGZRYrUvrOc1sooiQ+QdEk1suS1wo+oucsUAAAAABfXhAAAAAAAAAAAC6i5yxQAAAEDedJzbQLi0WzudRmn8/iRPOmY8QdhoBM23MZxTiY7A6vGsI8mvVOlWcBKL/x3czQCFFctrZzm0j2zv2Fzj/D4E0odkfgAAAEC08u+7w48yJpcR8MJmK/LKdHlD+wV8xbCo4EgSrjAlJvOXbgPPi6pV2OXHKooA6R2x58og1+uRxoRNmsNhFTwF"
 	assert.Equal(t, expected, received, "Base 64 XDR should match")
 }