Typography fixes for merged Branding PR's

[ricardobaeta]

This PR fixes the identified issues on the UI, after we merged Branding typography PR #139 and Adds UI Elements Branding to UI PR #142

The issues solved are listed bellow:

• Buttons does not keep size on action Buttons does not keep size on action #185
• Extra outer scrollbar in SQL lab results Extra outer scrollbar in SQL lab results #184
• UAST tab changes some global styles UAST tab changes some global styles. #183
• UAST buttons in result tables has no margins UAST buttons in result tables has no margins #186
• Breakdown chart is broken Breakdown chart is broken #192

Signed-off-by: Ricardo Baeta [email protected]

[dpordomingo]

I see no technical problems but I hadn't time to test it locally

[carlosms]

The other issues listed seem to be fixed.

But the sql lab results is not working properly right now.

In this PR, when the table is too tall, the scrollbar is half hidden. If I try to scroll to the bottom of the table, I can't. Without the outer scrollbar some contents just disappear.

When the results table is too wide I can't see the bottom scrollbar:

This is how it looks in v0.3.0-rc.1.

Too tall:

Too wide:

And in master (97fcccf). Here you can see the bottom is just a little bit clipped, the horizontal scrollbar is half-hidden.

Too tall:

Too wide:

[carlosms]

In case it wasn't clear in my previous comment, I think #184 is something that we can improve, but at worst is not much than an inconvenience. While the changes in this PR can be considered a bug.
I'll block this PR as it is, but I would be OK removing the changes for the results table and fixing #184 separately at some point later.

[ricardobaeta]

Hi @carlosms Thanks for the prompt review! No need to block this PR. The issues with #184 are fixed by my latest commit 9efe159. Look at 👇

[carlosms]

After testing the last commit 9efe159, I've noticed 2 problems.

1. There is always a horizontal scrollbar, even when the results fit.

9efe159:

v0.3.0-rc.1

When the results table is too tall, the vertical scroll gets hidden:

2. The results table now has a fixed height that does not make use of the whole window.

In 9efe159:

In v0.3.0-rc.1: See the gif used in point 1, it can be seen that the table has a fixed height and a lot of white space below it.

.

Since this doesn't look like a straight forward fix, I'd suggest to remove any related code from this PR, leave #184 as a known issue for now since it's mostly a cosmetic thing, and fix it independently later.

[ricardobaeta]

Thank you once again @carlosms. My latest commit 30fb5e7 removed the #184 related code, and I agree to tackle this issue on a further PR.

[ricardobaeta]

Thanks @carlos! I already pushed a commit 40f95cc with min-width.

[ricardobaeta]

Thanks @carlos! I already pushed a commit 9884af9 with min-width.

[dpordomingo]

LGTM,
I only found this issue #199, but was not created by this PR, so I'd say merge