Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UAST tab changes some global styles. #183

Closed
dpordomingo opened this issue Jun 29, 2019 · 3 comments
Closed

UAST tab changes some global styles. #183

dpordomingo opened this issue Jun 29, 2019 · 3 comments
Assignees
@ricardobaeta
Labels
bug Something isn't working product-design Visual, branding, typography

Comments

@dpordomingo
Copy link
Contributor

Originally posted by @carlosms in #139 (comment)

I see the UAST tab changes some of the global styles. I have only noticed it in the top-right "New" button, it gets bigger. But there might be other places:

a

b
@dpordomingo dpordomingo added bug Something isn't working product-design Visual, branding, typography labels Jun 29, 2019
@dpordomingo
Copy link
Contributor Author

@ricardobaeta I think this issue would be solved by adding , html into srcd/superset/assets/stylesheets/less/custom-brand.less#L128 as done in srcd/superset/assets/src/uast/override.less#L5

@dpordomingo dpordomingo mentioned this issue Jun 29, 2019
Merged
@ricardobaeta ricardobaeta self-assigned this Jun 30, 2019
ricardobaeta added a commit that referenced this issue Jul 4, 2019
@ricardobaeta
Fixes typography issues on Typography merged PR
4048da1 
This commit fixes the issues listed bellow, after we merged the Typography PR.

1) #185
2) #184
3) #183
4) #186

I'll be doing another commit to solve #192 and then will create a PR.

Signed-off-by: Ricardo Baeta <[email protected]>
ricardobaeta added a commit that referenced this issue Jul 4, 2019
@ricardobaeta
Fixes UAST tab changes some global styles issue
a0db1fd 
This fixes

UAST tab changes some global styles #183

Signed-off-by: Ricardo Baeta <[email protected]>
@ricardobaeta
Copy link
Contributor

Hi @dpordomingo ! This issue is now fixed as you can see 👇 . It will be included on the typography-fixes PR. Once it's merged we close this.

image

@ricardobaeta ricardobaeta mentioned this issue Jul 4, 2019
Merged
@carlosms
Copy link
Contributor

carlosms commented Jul 5, 2019

Fixed in #196

@carlosms carlosms closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardobaeta ricardobaeta

Labels
bug Something isn't working product-design Visual, branding, typography
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlosms @ricardobaeta @dpordomingo