Adds UI Elements Branding to UI #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpordomingo
force-pushed
the
sourced-ui-branding
branch
from
75254bf
to
5c71b96
Compare
|
@ricardobaeta I rebased this PR on top of #139 |
dpordomingo
approved these changes
Jun 27, 2019
Merged
This commit addresses the main ui elements (interactive & components) as defined and agreed on the design document. Signed-off-by: Ricardo Baeta <[email protected]>
dpordomingo
force-pushed
the
sourced-ui-branding
branch
from
5c71b96
to
46750ea
Compare
|
In which state is this PR @ricardobaeta? |
|
@dpordomingo The state of this PR is what is explained in the description. We can merge this and continue to work on it, I believe. |
smacker
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on Branding Typography PR. Therefore, we should be reviewing only the last commit.
Regarding 2019-R6-CE's source{d}-branded superset UI EPIC, the next step was to move forward with our branding design document objectives: Main UI components and UI Interactive elements.
This PR addresses the two objectives above. Keep in mind that we're not able yet to fully control every single UI element/interactive, that being said this means that you might find some outlier elements on the UI that will be handled as soon as possible, and addressing your review on this PR as well.
We are aware that the outlier elements shouldn't block this PR to be merged. We're making the best possible effort to take care of the outliers, but they're not a blocker.
The UI Elements/Interactive that this PR addresses specifically are on:
Known issues: Please don't consider branding on UAST Lab Navbar, Run Parser, UI Elements
SQL Lab
Before:
After:
Dashboards
Before:
After:
Dashboard
Before:
After:
Chart
Before:
After:
