Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spring.spel.ignore and spring.xml.ignore flags #29277

Closed
sdeleuze opened this issue Oct 7, 2022 · 0 comments
Closed

Remove spring.spel.ignore and spring.xml.ignore flags #29277

sdeleuze opened this issue Oct 7, 2022 · 0 comments
Assignees
@sdeleuze
Labels
type: task A general task
Milestone
6.0.0-RC1

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 7, 2022

Those undocumented flags were introduced for Spring Native experimental project needs but:

  • With Java 17 baseline, XML mashalling/unmarshalling support now requires an additional dependency like org.glassfish.jaxb:jaxb-runtime so the regular classpath check should now work as expected.
  • Removing SpEL support from the runtime path has a limited impact, and the right why to provide an efficient optimization should be to perform SpEL evaluation via Ahead Of Time transformation (not yet supported).

As a consequence, we are removing those flags from Spring Framework 6.
@sdeleuze sdeleuze added the type: task A general task label Oct 7, 2022
@sdeleuze sdeleuze added this to the 6.0.0-RC1 milestone Oct 7, 2022
@sdeleuze sdeleuze self-assigned this Oct 7, 2022
@sbrannen sbrannen mentioned this issue Oct 7, 2022
Closed
@sdeleuze sdeleuze mentioned this issue Oct 10, 2022
Closed
@bclozel bclozel mentioned this issue Oct 12, 2022
Closed
wilkinsona pushed a commit to spring-projects/spring-boot that referenced this issue Oct 12, 2022
@sdeleuze @wilkinsona
Remove spring.xml.ignore flag usages
5b17cac 
This commit is a follow-up of spring-projects/spring-framework#29277.

See gh-32653
@sdeleuze sdeleuze mentioned this issue Nov 21, 2022
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Nov 21, 2022
@sdeleuze
Make SourceHttpMessageConverter optional
1e98fb6 
As a follow-up to spring-projectsgh-29277, and since the JAXB support is now
triggered by the classpath presence of a JAXB implementation,
it makes sense to make SourceHttpMessageConverter, previously
configured unconditionally, optional.

That makes a big difference on native (1M of RSS reduction
with current typical Spring Boot 3 arrangement, 3.4M when
other usages of XML are not reachable).

It also brings more consistency between Spring MVC
and Spring WebFlux, and means that XML support for
Spring web applications now needs to be enabled explicitly.

As a consequence, Spring web applications using
javax.xml.transform.Source now needs to configure
SourceHttpMessageConverter explicitly in RestTemplate or
Spring MVC.

Closes spring-projectsgh-29535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
type: task A general task
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@sdeleuze