Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation for spring.spel.ignore and spring.xml.ignore #28726

Closed
joca-bt opened this issue Jun 29, 2022 · 5 comments
Closed

Missing documentation for spring.spel.ignore and spring.xml.ignore #28726

joca-bt opened this issue Jun 29, 2022 · 5 comments
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation task

Comments

@joca-bt
Copy link

joca-bt commented Jun 29, 2022

Properties spring.spel.ignore (#25153) and spring.xml.ignore (#25151) are not documented. Other similar properties are documented in the appendix https://docs.spring.io/spring-framework/docs/current/reference/html/appendix.html so I think it would make sense to add these there as well.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 29, 2022
@sbrannen
Copy link
Member

This omission is intentional. These two specific properties are not considered "supported", and the table in the appendix "lists all currently supported Spring properties".

However, since these unsupported properties have existed for a while and are used in conjunction with applications running within a native image, the team will revisit this topic.

@sbrannen sbrannen added the type: documentation A documentation task label Jun 29, 2022
@sbrannen sbrannen added this to the Triage Queue milestone Jun 29, 2022
@sdeleuze
Copy link
Contributor

Let's maybe decide what we do on Spring Framework 6 timeframe for those, the ideal outcome would be to remove those flags, removing the need for documentation.

@adrianbob
Copy link
Contributor

Hey,
I'm new to open source contributing. Please let me know if it would be ok to open a PR for this issue for removing those properties. Thanks!

@sbrannen
Copy link
Member

sbrannen commented Jul 1, 2022

Hi @adrianbob,

Thanks for the offer.

Please note, however, that this is an issue that will be decided within the core team.

In light of that, a PR for removal would not be appropriate at this time.

@sbrannen sbrannen changed the title Missing documentation for spring.spel.ignore and spring.xml.ignore Missing documentation for spring.spel.ignore and spring.xml.ignore Oct 7, 2022
@sbrannen
Copy link
Member

sbrannen commented Oct 7, 2022

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
@sbrannen sbrannen added status: invalid An issue that we don't feel is valid status: superseded An issue that has been superseded by another and removed for: team-attention status: waiting-for-triage An issue we've not yet triaged or decided on status: invalid An issue that we don't feel is valid labels Oct 7, 2022
@sbrannen sbrannen removed this from the Triage Queue milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

6 participants