Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SourceHttpMessageConverter optional #29535

Closed
sdeleuze opened this issue Nov 21, 2022 · 0 comments
Closed

Make SourceHttpMessageConverter optional #29535

sdeleuze opened this issue Nov 21, 2022 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Nov 21, 2022

As a follow-up to #29277, and since the inclusion of JAXB support is triggered by the classpath presence of a JAXB implementation, it makes sense to make SourceHttpMessageConverter, currently configured unconditionally, optional. That makes a big difference on native (1M of RSS reduction with current typical Spring Boot 3 arrangement, 3.4M when other usages of XML will be not be reachable by default anymore like in Tomcat or Logback) and will avoid to configure XML support by default on JVM as well without an explicit signal.

As a consequence, Spring applications using DOMSource, SAXSource, StAXSource, StreamSource or Source will need to configure SourceHttpMessageConverter explicitly in RestTemplate or Spring MVC. This will be properly documented on upgrade notes.

@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 21, 2022
@sdeleuze sdeleuze added this to the 6.0.1 milestone Nov 21, 2022
@sdeleuze sdeleuze self-assigned this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant