Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.rabbitmq.listener.stream.auto-startup property has no effect #38749

Closed
mhalbritter opened this issue Dec 12, 2023 · 4 comments
Closed
Assignees
Labels
status: superseded An issue that has been superseded by another

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 12, 2023

The property comes from org.springframework.boot.autoconfigure.amqp.RabbitProperties.BaseContainer#isAutoStartup, which inherits it to SimpleContainer, DirectContainer, and StreamContainer.

The property is read for SimpleContainer and DirectContainer in org.springframework.boot.autoconfigure.amqp.AbstractRabbitListenerContainerFactoryConfigurer, but nothing reads it on the StreamContainer, therefore the property has no effect for the Stream listener.

There's also no setAutoStartup on the StreamRabbitListenerContainerFactory.

I think we should move the property from BaseContainer to AmqpContainer, which is the super class of SimpleContainer and DirectContainer, but not StreamContainer.

@mhalbritter mhalbritter added the type: bug A general bug label Dec 12, 2023
@mhalbritter mhalbritter added this to the 3.1.x milestone Dec 12, 2023
@BenchmarkingBuffalo
Copy link
Contributor

Hi @mhalbritter,
I would like to fix this bug and I am willing to create a PR for it.
The question is, do we keep the empty class/interface BaseContainer or do we remove it?
It seems not to be used anywhere in the code of the framework, but maybe someone else has a project relying on it.

@mhalbritter
Copy link
Contributor Author

Hello,

#36451 has added a new field to the BaseContainer on the main branch, so we have to keep it. I'll assign this issue to you. If you need any help, please don't hesitate to reach out.

BenchmarkingBuffalo added a commit to BenchmarkingBuffalo/spring-boot that referenced this issue Jan 9, 2024
Move the property 'autoStartup' from BaseContainer to AmqpContainer. Fix spring-projectsgh-38749
@BenchmarkingBuffalo
Copy link
Contributor

Hi @mhalbritter,
PR is here. If I need to change something, please let me know.
The tests for this attribute have already been in the correct places, so no changes here.
If I should also create a PR for the main branch because of the merge conflicts due to #36451, just tell me.

@mhalbritter
Copy link
Contributor Author

Superseded by #39072. Thank you!

@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
@mhalbritter mhalbritter added status: superseded An issue that has been superseded by another and removed type: bug A general bug labels Jan 10, 2024
@mhalbritter mhalbritter removed this from the 3.1.x milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

2 participants