Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.rabbitmq.listener.stream.auto-startup property has no effect #39072

Conversation

BenchmarkingBuffalo
Copy link
Contributor

Move the property 'autoStartup' from BaseContainer to AmqpContainer. Fix #38749

As described in the issue, this property is only used by the child classes of the AmqpContainer.
The empty BaseContainer class is kept, because in the main branch, other attributes have been added to it.

Because of the affected lines, there might appear merge conflicts with the main branch.
If needed, I can create a PR for that as well.

Move the property 'autoStartup' from BaseContainer to AmqpContainer. Fix spring-projectsgh-38749
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 9, 2024
@mhalbritter mhalbritter added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 10, 2024
@mhalbritter mhalbritter added this to the 3.1.x milestone Jan 10, 2024
@mhalbritter mhalbritter changed the title Move autoStartup property spring.rabbitmq.listener.stream.auto-startup property has no effect Jan 10, 2024
@mhalbritter mhalbritter self-assigned this Jan 10, 2024
mhalbritter pushed a commit that referenced this pull request Jan 10, 2024
Move the property 'autoStartup' from BaseContainer to AmqpContainer.

See gh-39072
@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.8 Jan 10, 2024
@BenchmarkingBuffalo BenchmarkingBuffalo deleted the 38749-move-auto-startup-property branch January 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants