Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'observation-enabled' properties for RabbitMQ #36451

Closed
garyrussell opened this issue Jul 19, 2023 · 3 comments
Closed

Add 'observation-enabled' properties for RabbitMQ #36451

garyrussell opened this issue Jul 19, 2023 · 3 comments
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone

Comments

@garyrussell
Copy link
Contributor

Spring AMQP does not enable Observation by default; if a user only wants Micrometer timers, it is better to use the legacy timers provided by the project, which detects the presence (or not) of a MeterRegistry bean.

However, if a user wants tracing, the observationEnabled property must be set to true; it would be more convenient if Boot provided this as an auto config property.

Furthermore, if Boot can detect that tracing is enabled (not just timers via Observation), then the properties could default to true, if not set by the user. If no such detection is possible, then the properties should remain at their default, false.

The observationEnabled property is available on BaseRabbitListenerContainerFactory and RabbitTemplate.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 19, 2023
@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 24, 2023
@scottfrederick scottfrederick added this to the 3.x milestone Jul 24, 2023
@scottfrederick scottfrederick added the theme: observability Issues related to observability label Jul 24, 2023
@mhalbritter mhalbritter modified the milestones: 3.x, 3.3.x Nov 24, 2023
@philwebb philwebb changed the title Add observationEnabled properties for RabbitMQ Add 'observation-enabled' properties for RabbitMQ Dec 11, 2023
@mhalbritter
Copy link
Contributor

@sirlatrom
Copy link

Sorry if this is the wrong place to ask, but is this likely to be back ported to the 3.2.x or 3.1.x branches?

@scottfrederick
Copy link
Contributor

@sirlatrom We only do bug fixes and dependency upgrades in patch releases, so this enhancement will not be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants