Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[easy] Warn about the deprecation of the MaxProject filter #1390

Merged
merged 1 commit into from
Jun 19, 2019
Merged

[easy] Warn about the deprecation of the MaxProject filter #1390

merged 1 commit into from
Jun 19, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Jun 3, 2019

Depends on #1386

@ttung
Copy link
Collaborator Author

ttung commented Jun 3, 2019

I can see this being controversial, so I'm flagging a bunch of ppl. :)

@codecov-io
Copy link

codecov-io commented Jun 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@993258a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1390   +/-   ##
=========================================
  Coverage          ?   89.43%           
=========================================
  Files             ?      152           
  Lines             ?     5556           
  Branches          ?        0           
=========================================
  Hits              ?     4969           
  Misses            ?      587           
  Partials          ?        0
Impacted Files Coverage Δ
starfish/core/image/_filter/max_proj.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993258a...8543e06. Read the comment docs.

@ttung ttung force-pushed the tonytung-reduce branch from fd66303 to d9bfa9d Compare June 6, 2019 22:47
@ttung ttung force-pushed the tonytung-max-proj-deprecated branch from 4010109 to 919124f Compare June 6, 2019 22:47
@ttung ttung force-pushed the tonytung-max-proj-deprecated branch from 919124f to 6ab47bd Compare June 12, 2019 18:50
@ttung ttung force-pushed the tonytung-reduce branch from 0347021 to b44147e Compare June 19, 2019 07:40
@ttung ttung force-pushed the tonytung-max-proj-deprecated branch from 6ab47bd to 1f7c189 Compare June 19, 2019 07:40
@ttung ttung force-pushed the tonytung-reduce branch from b44147e to 9e7557d Compare June 19, 2019 07:44
@ttung ttung force-pushed the tonytung-max-proj-deprecated branch from 1f7c189 to 5fff90c Compare June 19, 2019 07:44
@ttung ttung force-pushed the tonytung-reduce branch from 9e7557d to cfcbd63 Compare June 19, 2019 07:50
@ttung ttung force-pushed the tonytung-max-proj-deprecated branch 2 times, most recently from 8ecc90f to 36eeb41 Compare June 19, 2019 18:38
@ttung ttung changed the base branch from tonytung-reduce to master June 19, 2019 18:42
@ttung ttung force-pushed the tonytung-max-proj-deprecated branch from 36eeb41 to 8543e06 Compare June 19, 2019 18:45
@ttung ttung merged commit 69713dd into master Jun 19, 2019
@ttung ttung deleted the tonytung-max-proj-deprecated branch June 19, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanaxel42 shanaxel42 shanaxel42 approved these changes

@kevinyamauchi kevinyamauchi Awaiting requested review from kevinyamauchi

@dganguli dganguli Awaiting requested review from dganguli

@ambrosejcarr ambrosejcarr Awaiting requested review from ambrosejcarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @shanaxel42