Skip to content

Commit

Permalink
[easy] Warn about the deprecation of the MaxProject filter (#1390)
Browse files Browse the repository at this point in the history
Depends on #1386
  • Loading branch information
Tony Tung authored Jun 19, 2019
1 parent 23de97b commit 69713dd
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions starfish/core/image/_filter/max_proj.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import warnings
from typing import Iterable, Optional, Union

from starfish.core.imagestack.imagestack import ImageStack
Expand All @@ -23,6 +24,10 @@ class MaxProject(FilterAlgorithmBase):

def __init__(self, dims: Iterable[Union[Axes, str]]) -> None:

warnings.warn(
"Filter.MaxProject is being deprecated in favor of Filter.Reduce(func='max')",
DeprecationWarning,
)
self.dims = dims

_DEFAULT_TESTING_PARAMETERS = {"dims": 'r'}
Expand Down

0 comments on commit 69713dd

Please sign in to comment.