Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] Warn about the deprecation of the MaxProject filter #1390

Merged
merged 1 commit into from
Jun 19, 2019
Merged

[easy] Warn about the deprecation of the MaxProject filter #1390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions starfish/core/image/_filter/max_proj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import warnings
from typing import Iterable, Optional, Union

from starfish.core.imagestack.imagestack import ImageStack
Expand All @@ -23,6 +24,10 @@ class MaxProject(FilterAlgorithmBase):

def __init__(self, dims: Iterable[Union[Axes, str]]) -> None:

warnings.warn(
"Filter.MaxProject is being deprecated in favor of Filter.Reduce(func='max')",
DeprecationWarning,
)
self.dims = dims

_DEFAULT_TESTING_PARAMETERS = {"dims": 'r'}
Expand Down