Unit Testing for sdl_android Project #88
Conversation
mikeburke106
added
REVIEW - scheduled
mikeburke106
changed the title
mikeburke106
changed the title
mikeburke106
added
the
REVIEW - scheduled
mikeburke106
removed
the
REVIEW - scheduled
|
Here are the results of the unit tests for this PR (tested on master at the time this repo was forked). Note that this PR needs to be re-based, so some issues have recently been fixed but are still showing failures. These failed tests should pass after re-basing the branch.
The difference between a test failure and a test error is that a failure successfully runs through the test code, but at least one of the test assertions was failed, while a test error crashes while executing the test code due to an exception that wasn't caught by the test. Of the 147 failed tests, 75 are related to defensive-copying (#11), 17 are related to enums not handling valueForString consistently (#91), 32 are resolved issues that need to be re-based, 10 are bugs in the mobile libraries (#71 & #102) and the remaining 13 are issues with the tests themselves. Livio is working to fix the test errors and get the tests to a state where all failures represent real issues that are posted to Github issues. We are also working on increasing unit test coverage as far as possible. |
…ndroid into feature/unit_tests Signed-off-by: Mike Burke <[email protected]> Conflicts: sdl_android_tests/src/com/smartdevicelink/test/rpc/datatypes/DisplayCapabilitiesTests.java
Signed-off-by: Mike Burke <[email protected]>
…ndroid into feature/unit_tests
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
mikeburke106
added
the
REVIEW - scheduled
|
Adding unit tests should really be a hotfix, so I'm pushing this up from v4.0.0 to v3.4.0. We should get this in ASAP so new PRs can unit test their changes more easily. RPC classes and enums are thoroughly tested so far. All tests are either passed or failed with bug reported in Github. |
|
Has anyone reviewed the existing unit tests at all? We have about 1,500 written so far, but I would like to know any corner cases we might be missing that should be tested for. Right now, we're only testing RPC classes & enums because they are well defined and encapsulated in the code, but we definitely need to keep adding test cases. Some pieces of the code will be practically impossible to unit test due to statefulness, dependencies and architecture issues, but we should identify some other classes that could be unit tested. |
|
Need to do the following before this can be merged:
|
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
|
Closed due to another PR being used. |
joeygrover
added
REVIEW - rejected
💥 READY FOR REVIEW 💥
Related to issue #17 .
Summary
This is the first-round of unit tests for the Android mobile libraries. More unit tests will be written in the future and unit tests should be updated whenever an API change occurs.
This pull request adds unit testing to RPC classes. The code was originally pulled from GENIVI's unit test branch at smartdevicelink_android.git
This commit tests all RPC objects. Each RPC object should test every available API method and ensure they work correctly. Currently, failed tests are related to #11, #52, #71 and #80.
Unit tests should be modified as additional code is added to the project and unit tests should be run on all code prior to an official release (this should happen on the release branch). Any issues that arise should have a unit test written for it showing failure before the issue is fixed and passed after the fix is applied.