Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong argument in DisplayCapabilities method #52

Closed
crokita opened this issue Jan 20, 2015 · 1 comment
Closed

Wrong argument in DisplayCapabilities method #52

crokita opened this issue Jan 20, 2015 · 1 comment
Labels
bug A defect in the library REVIEW - scheduled The reviewer has scheduled a review of this PR for the current sprint

Comments

@crokita
Copy link

crokita commented Jan 20, 2015

com.smartdevicelink.proxy.rpc.DisplayCapabilities has this method:
160: setImageFields( List<TextField> imageFields )
The parameter should be of type List<ImageField>
@mikeburke106
Copy link
Contributor

Good find, Chris. We actually already fixed this issue in commit 8196a01, but it looks like it was incorrectly merged back in in commit 43d5fd5.

This is why the unit test stuff you're working on is so important. Little mistakes like this can be found more easily. Keep up the good work.

@mikeburke106 mikeburke106 added bug A defect in the library REVIEW - scheduled The reviewer has scheduled a review of this PR for the current sprint labels Jan 21, 2015
mikeburke106 pushed a commit to mikeburke106/sdl_android that referenced this issue Jan 22, 2015
Fixes smartdevicelink#52
7f05773 
Signed-off-by: Mike Burke <[email protected]>
@mikeburke106 mikeburke106 mentioned this issue Jan 22, 2015
Merged
@crokita crokita mentioned this issue Jan 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library REVIEW - scheduled The reviewer has scheduled a review of this PR for the current sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeburke106 @crokita