Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException in PerformAudioPassThru get method #80

Closed
crokita opened this issue Jan 27, 2015 · 1 comment · Fixed by #81
Closed

NullPointerException in PerformAudioPassThru get method #80

crokita opened this issue Jan 27, 2015 · 1 comment · Fixed by #81
Labels
bug A defect in the library REVIEW - scheduled The reviewer has scheduled a review of this PR for the current sprint

Comments

@crokita
Copy link

crokita commented Jan 27, 2015

For the PerformAudioPassThru class, if a new PerformAudioPassThru object is made and calls getMaxDuration a NullPointerException occurs trying to return an int.
@mrapitis
Copy link
Contributor

Very true, we should be returning an Integer type here (which allows nulls).

@mikeburke106 mikeburke106 added the bug A defect in the library label Jan 27, 2015
mikeburke106 pushed a commit that referenced this issue Jan 27, 2015
Fixes #80.
d961165 
Changed return type of getMaxDuration from int to Integer

Signed-off-by: Mike Burke <[email protected]>
@mikeburke106 mikeburke106 mentioned this issue Jan 27, 2015
Merged
@crokita crokita mentioned this issue Jan 29, 2015
Closed
@mikeburke106 mikeburke106 added the REVIEW - scheduled The reviewer has scheduled a review of this PR for the current sprint label Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library REVIEW - scheduled The reviewer has scheduled a review of this PR for the current sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed return type of getMaxDuration in PerformAudioPassThru class smartdevicelink/sdl_java_suite
3 participants
@mikeburke106 @mrapitis @crokita