-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.3.0 Release #2046
Merged
Merged
v7.3.0 Release #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj
* Added menu replace op unit tests * Updated MenuCellState to a more descriptive title * Updated printing a run score to be much clearer * Add a null check to menu replace utilities * Make MenuCell copyable * Fix MenuCell missing private property causing a crash
* Fix checking wrong image field causing no images to be uploaded
# Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj # SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-Swift.xcscheme
…-manager-refactor Menu Manager Refactor and Updating Implementation
…etion-handlers-not-called Fix completion handlers not being called
…ploads # Conflicts: # SmartDeviceLink/private/SDLDeleteFileOperation.m # SmartDeviceLink/public/SDLFileManager.m
…manager-multiple-uploads Fix file operations check file system at queue time instead of run time
Codecov Report
@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
- Coverage 86.32% 85.82% -0.50%
==========================================
Files 441 447 +6
Lines 22792 23299 +507
==========================================
+ Hits 19675 19997 +322
- Misses 3117 3302 +185 |
…configuration-update-crash Fix menu configuration update crash
…ng-menu-cell-no-submenu-layout Fix submenu layout is not copied on menu cells
Co-authored-by: Joel Fischer <[email protected]>
…ional-check-when-processing-control-messages Additional check added when processing control messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk
This PR makes minor API changes.
Testing Plan
A full suite of smoke tests will be performed.
Summary
Testing
Bug Fixes
Other
CLA