Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion handlers not being called #2045

Merged

Conversation

joeljfischer
Copy link
Contributor

Fixes #2044

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

None

Core Tests

Basic connection test with Manticore

Core version / branch / commit hash / module tested against: Manticore (Core v7.1.0)
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.10.0)

Summary

This PR fixes warnings from Xcode 13 about code paths that don't result in the completion handler being called

Changelog

Bug Fixes
  • Fixed code paths that resulted in a completion handler never being called

Tasks Remaining:

None

CLA

@joeljfischer joeljfischer added the best practice Not a defect but something that should be improved anyway label Sep 24, 2021
@joeljfischer joeljfischer self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #2045 (68547aa) into develop (095d0a2) will increase coverage by 71.86%.
The diff coverage is 20.58%.

❗ Current head 68547aa differs from pull request most recent head d888ebe. Consider uploading reports for the commit d888ebe to get more accurate results

@@             Coverage Diff              @@
##           develop    #2045       +/-   ##
============================================
+ Coverage    13.99%   85.85%   +71.86%     
============================================
  Files          447      447               
  Lines        23237    23291       +54     
============================================
+ Hits          3252    19997    +16745     
+ Misses       19985     3294    -16691     

Copy link
Contributor

@FrankElias77 FrankElias77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes needed in the example apps

@joeljfischer joeljfischer merged commit 6eaf543 into develop Sep 27, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-2044-completion-handlers-not-called branch September 27, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants