Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submenu layout is not copied on menu cells #2053

Merged

Conversation

joeljfischer
Copy link
Contributor

Fixes #2048

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests for copying SDLMenuCell are added

Core Tests

Created a cell with a submenu with the submenu layout as TILES

Core version / branch / commit hash / module tested against: Manticore (Core v7.1.1)
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI

Summary

This PR fixes copying a menu cell does not copy the submenu layout

Changelog

Bug Fixes
  • Fixed submenu cells not using the submenu layout

Tasks Remaining:

n/a

CLA

@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Oct 21, 2021
@joeljfischer joeljfischer self-assigned this Oct 21, 2021
@joeljfischer joeljfischer merged commit 53e43be into develop Oct 21, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-2048-copying-menu-cell-no-submenu-layout branch October 21, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants