Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash occurs when an unknown incoming RPC is received #1713

Closed
joeljfischer opened this issue Jul 15, 2020 · 0 comments
Closed

Crash occurs when an unknown incoming RPC is received #1713

joeljfischer opened this issue Jul 15, 2020 · 0 comments
Assignees
@joeljfischer
Labels
bug A defect in the library protocol Relating to the protocol layer

Comments

@joeljfischer
Copy link
Contributor

Bug Report

When receiving an unknown incoming RPC, the library attempts to convert it into an RPC class, which fails, making it nil. This nil is then passed up the chain where the data is expected to not be nil. We should just discard the unknown RPC when we can't turn it into something known.

Reproduction Steps
  1. Connect to Sync 3.4
  2. Send it an OnCommand notification
  3. Note the reception of an OnCommand Response, which is not an actual RPC type.
Expected Behavior

No crash occurs

Observed Behavior

A crash occurs

OS & Version Information
  • iOS Version: 13.5
  • SDL iOS Version: 6.7.0-develop
  • Testing Against: Ford Sync 3.4
Test Case, Sample Code, and / or Example App

n/a
@joeljfischer joeljfischer added bug A defect in the library protocol Relating to the protocol layer labels Jul 15, 2020
@joeljfischer joeljfischer self-assigned this Jul 15, 2020
joeljfischer added a commit that referenced this issue Jul 15, 2020
@joeljfischer
Fix unknown RPC crash #1713
cae8bfb
@joeljfischer joeljfischer mentioned this issue Jul 15, 2020
Merged
4 tasks
@joeljfischer joeljfischer mentioned this issue Jul 16, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeljfischer