Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown RPC crash #1714

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

joeljfischer
Copy link
Contributor

Fixes #1713

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

No unit test changes

Core Tests

Tested receiving the errant RPC type from Sync 3.4

Core version / branch / commit hash / module tested against: Ford Sync 3.4
HMI name / version / branch / commit hash / module tested against: Ford Sync 3.4

Summary

If a received protocol message cannot be turned into an RPC, discard it.

Changelog

Bug Fixes
  • When an unknown RPC is received, discard it instead of crashing.

CLA

@joeljfischer joeljfischer added bug A defect in the library protocol Relating to the protocol layer labels Jul 15, 2020
@joeljfischer joeljfischer self-assigned this Jul 15, 2020
@joeljfischer joeljfischer changed the title Fix unknown RPC crash #1713 Fix unknown RPC crash Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1714 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1714      +/-   ##
===========================================
+ Coverage    83.79%   83.81%   +0.02%     
===========================================
  Files          407      407              
  Lines        20811    20813       +2     
===========================================
+ Hits         17438    17444       +6     
+ Misses        3373     3369       -4     

@joeljfischer joeljfischer merged commit 905175d into develop Jul 16, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1713-fix-crash-unknown-rpc branch July 16, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants