Fix unknown RPC crash #1713

smartdevicelink · Jul 15, 2020 · cae8bfb · cae8bfb
1 parent 280d05c
commit cae8bfb
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/SmartDeviceLink/SDLLifecycleProtocolHandler.m b/SmartDeviceLink/SDLLifecycleProtocolHandler.m
@@ -142,6 +142,9 @@ - (void)onProtocolMessageReceived:(SDLProtocolMessage *)msg {
     NSString *functionClassName = [NSString stringWithFormat:@"SDL%@", fullName];
     SDLRPCMessage *newMessage = [[NSClassFromString(functionClassName) alloc] initWithDictionary:rpcMessageAsDictionary];
 
+    // If we were unable to create the message, it's an unknown type; discard it
+    if (newMessage == nil) { return; }
+
     // Adapt the incoming message then call the callback
     NSArray<SDLRPCMessage *> *adaptedMessages = [SDLLifecycleRPCAdapter adaptRPC:newMessage direction:SDLRPCDirectionIncoming];
     for (SDLRPCMessage *message in adaptedMessages) {