Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bm browse view #305

Merged
merged 76 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
812ff8d
Title styling layout tweaks
Bianca-Morris Dec 1, 2024
0918f60
Pull out benchmarking ui into separate component
Bianca-Morris Dec 1, 2024
ceb3495
Rework benchmarking to use new component
Bianca-Morris Dec 1, 2024
b3c6226
Add some basic layout components
Bianca-Morris Dec 1, 2024
fad0c49
Icon fix + add above facet component
Bianca-Morris Dec 2, 2024
082410e
Merge branch 'main' of https://github.com/smaht-dac/smaht-portal into…
Bianca-Morris Dec 2, 2024
44502c2
Get selection boxes working
Bianca-Morris Dec 2, 2024
df42970
Start BrowseViewAboveTableComponent
Bianca-Morris Dec 5, 2024
d7e98fd
Style tweak for above-facets-table-row
Bianca-Morris Dec 12, 2024
2e469d0
Fix column styling
Bianca-Morris Dec 12, 2024
035d4e1
Rework above table controls
Bianca-Morris Dec 12, 2024
34f3ed2
include 'status' facet in peek-metadata resp
Bianca-Morris Dec 12, 2024
8ac021c
Replace static statistics with dynamic ones (released files only)
Bianca-Morris Dec 12, 2024
b31df48
Re-add alerts to Browse View
Bianca-Morris Dec 12, 2024
2fc47ee
Add some static breadcrumbs
Bianca-Morris Dec 12, 2024
790a85f
Disable browse links for unimplemented item types
Bianca-Morris Dec 12, 2024
fda2b10
Improve styling on tablet and mobile
Bianca-Morris Dec 12, 2024
c083d6f
Bugfix for first column styling when customizing columns
Bianca-Morris Dec 12, 2024
00c349f
Add a bit to column definitions
Bianca-Morris Dec 12, 2024
4311b1b
Styling fixes for column alignment
Bianca-Morris Dec 12, 2024
88d3137
Column additions and tweaks
Bianca-Morris Dec 12, 2024
72e3280
add embed for donor and tissue information
Bianca-Morris Dec 12, 2024
bbc707e
Hide unnecessary facet
Bianca-Morris Dec 12, 2024
32ed41d
update browse page defaults
Bianca-Morris Dec 12, 2024
d27a88f
Merge branch 'dmichaels-20241119-browse-view' of https://github.com/s…
Bianca-Morris Dec 12, 2024
128fd89
add reference_genome embeds to file subtypes
Bianca-Morris Dec 17, 2024
6c9e25c
Tweak file embeds
Bianca-Morris Dec 17, 2024
257d8f4
Adjust scss to use new source of tissue display title
Bianca-Morris Dec 17, 2024
253c755
Add additional facets to file for browse search
Bianca-Morris Dec 17, 2024
44de938
Adjustments to columns and facets + statistics loading
Bianca-Morris Dec 17, 2024
936576e
Rework navbar
Bianca-Morris Dec 17, 2024
5c346ea
Navbar tweaks
Bianca-Morris Dec 17, 2024
bfd528d
Swap to Production
Bianca-Morris Dec 17, 2024
897ded7
update SPC to 0.1.92b1
Bianca-Morris Dec 17, 2024
c2b2ec7
Fix for header bg styling bug
Bianca-Morris Dec 17, 2024
58dee36
add data attribute for current at-type to body + fix for error stylin…
Bianca-Morris Dec 17, 2024
e3f5fcd
Move some things around for sake of cleanliness
Bianca-Morris Dec 18, 2024
c258bd4
Clean up logs + make session refresh view
Bianca-Morris Dec 18, 2024
f473c0a
Fix for search table arrow weirdness on browse view
Bianca-Morris Dec 18, 2024
f213ee6
Nav tweaks
Bianca-Morris Dec 18, 2024
280031a
Use new version of valueTransforms.byteToLargerUnit (needs version bu…
Bianca-Morris Dec 18, 2024
650d824
Tweak benchmarking nav titles
Bianca-Morris Dec 18, 2024
7b30039
Update breadcrumb copy + add comment
Bianca-Morris Dec 18, 2024
615b7f0
bump SPC to 0.1.92b2
Bianca-Morris Dec 18, 2024
a4b2df5
Add support for reference_genome to output, reference, variantcalls f…
Bianca-Morris Dec 18, 2024
9b61739
Tweak to donor.sex & .age facet fields; add data_category, data_type
Bianca-Morris Dec 19, 2024
9a5cf21
Remove tier 2 from homepage; rename remaining tiers
Bianca-Morris Dec 20, 2024
b6c22df
Keep TimelineAccordion drawers open when re-selecting
Bianca-Morris Dec 20, 2024
4102b55
Tweaks to activeKey & defaultActiveKey to support array
Bianca-Morris Dec 20, 2024
78594c0
Merge branch 'dmichaels-20241119-browse-view' of https://github.com/s…
Bianca-Morris Dec 20, 2024
62358f0
bump SPC 0.1.92b3 (fixes 4DN-CGAP style issues)
utku-ozturk Jan 2, 2025
63f7dac
Set sidebar to start collapsed on production page
Bianca-Morris Jan 9, 2025
4aa815e
Make sidebar nav smaller
Bianca-Morris Jan 9, 2025
11c42e1
Data summary styling changes
Bianca-Morris Jan 9, 2025
b3d3c61
Table and Facet Changes
Bianca-Morris Jan 9, 2025
3107d70
Update nav bar icons
Bianca-Morris Jan 9, 2025
e54bfd2
Make the gap absolutely friggin gigantic
Bianca-Morris Jan 9, 2025
41ec6f8
Tweak for dropdown menu file size
Bianca-Morris Jan 9, 2025
00132a4
Merge branch 'bm-browse-view' of https://github.com/smaht-dac/smaht-p…
Bianca-Morris Jan 9, 2025
24d2825
Merge branch 'dmichaels-20241119-browse-view' of https://github.com/s…
Bianca-Morris Jan 9, 2025
c70ec72
Merge branch 'main' of https://github.com/smaht-dac/smaht-portal into…
Bianca-Morris Jan 9, 2025
9e92313
Remove outdated comment
Bianca-Morris Jan 9, 2025
fb4e716
Styling tweaks + add image
Bianca-Morris Jan 13, 2025
a9aee00
Remove tier from nav
Bianca-Morris Jan 13, 2025
f81aa88
Additional tweaks
Bianca-Morris Jan 13, 2025
c0efa18
Bump SPC to official version of 0.1.92
Bianca-Morris Jan 13, 2025
3f8e8fc
Merge branch 'main' of https://github.com/smaht-dac/smaht-portal into…
Bianca-Morris Jan 13, 2025
a1f43eb
Remove beta from pyproject.toml
Bianca-Morris Jan 13, 2025
1c37730
Fix for donor age ranges + double labels
Bianca-Morris Jan 13, 2025
0dfb911
swap file_sets.libraries.analytes.samples.sample_sources.donor.age to…
Bianca-Morris Jan 13, 2025
1027ef4
Fix pyproject.toml
Bianca-Morris Jan 13, 2025
03dbfcb
fix facet
willronchetti Jan 16, 2025
f78e51b
tweak donor age facet
Bianca-Morris Jan 23, 2025
1f83cfa
Merge branch 'main' of https://github.com/smaht-dac/smaht-portal into…
Bianca-Morris Jan 23, 2025
d1ae2b5
Slight adjusments to changelog
Bianca-Morris Jan 23, 2025
1f11cfc
Cesar review tweaks + changelog update
Bianca-Morris Jan 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,25 @@ smaht-portal
Change Log
----------

0.127.0
=======
`PR 305: BM Browse View <https://github.com/smaht-dac/smaht-portal/pull/305>`_

* Implements UI of browse view + generalization of benchmarking layout
* Rework navbar to include new structure
* Adjustments to home page to include only two tiers
* Slight schema edits for facets and columns
* Update to SPC version 0.1.92


0.126.1
=======
`PR 313 SN Reference file columns <https://github.com/smaht-dac/smaht-portal/pull/313>`
`PR 313 SN Reference file columns <https://github.com/smaht-dac/smaht-portal/pull/313>`_

* Add `title` and `version` to columns for ReferenceFile
* Minor fix: remove Basecalling from the automated spreadsheet script


0.126.0
=======
`PR246: feat: homepage updates <https://github.com/smaht-dac/smaht-portal/pull/246>`_
Expand Down Expand Up @@ -60,7 +72,7 @@ Change Log

0.124.1
=======
`PR BM Register Text Fix <https://github.com/smaht-dac/smaht-portal/pull/297>`_
`PR 297: BM Register Text Fix <https://github.com/smaht-dac/smaht-portal/pull/297>`_

* Update text in UserRegistrationModal to not refer to 2023 data release

Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@gmod/tabix": "^1.5.3",
"@gmod/vcf": "^5.0.6",
"@hms-dbmi-bgm/react-workflow-viz": "0.1.11",
"@hms-dbmi-bgm/shared-portal-components": "github:4dn-dcic/shared-portal-components#0.1.91",
"@hms-dbmi-bgm/shared-portal-components": "github:4dn-dcic/shared-portal-components#0.1.92",
"@reduxjs/toolkit": "^2.2.6",
"auth0-lock": "^12.5.1",
"d3": "^7.8.5",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "encoded"
version = "0.126.1"
version = "0.127.0"
description = "SMaHT Data Analysis Portal"
authors = ["4DN-DCIC Team <[email protected]>"]
license = "MIT"
Expand Down
6 changes: 3 additions & 3 deletions src/encoded/browse.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ def includeme(config):

DEFAULT_BROWSE_PARAM_LISTS = {
"type": [DEFAULT_BROWSE_TYPE],
"additional_facet": DEFAULT_BROWSE_FACETS
"sample_summary.studies": ["Production"],
"status": ["released"],
# "additional_facet": DEFAULT_BROWSE_FACETS
}

@view_config(route_name='browse', request_method='GET', permission='search')
Expand Down Expand Up @@ -55,8 +57,6 @@ def browse(context, request, search_type=DEFAULT_BROWSE_TYPE, return_generator=F
detail="Redirected from " + str(request.path_info)
)

# TODO
# No real /browse specific UI yet; initially just basically copied static/components/SearchView.js to BrowseView.js.
return search(context, request, search_type, return_generator, forced_type="Browse")


Expand Down
19 changes: 2 additions & 17 deletions src/encoded/homepage.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def home(context, request):
'date': f'{time.strftime("%Y-%m-%d %H:%M")} EST',
'@graph': [
{
"title": "Tier 0: Benchmarking",
"title": "Benchmarking",
"subtitle": "with all technologies",
"categories": [
{
Expand Down Expand Up @@ -237,7 +237,7 @@ def home(context, request):
]
},
{
"title": "Tier 1",
"title": "Production",
"subtitle": "with core + additional technologies",
"categories": [
{
Expand All @@ -251,21 +251,6 @@ def home(context, request):
}
]
},
{
"title": "Tier 2",
"subtitle": "with core technologies",
"categories": [
{
"title": "Primary Tissues",
"figures": [
{ "value": 0, "unit": "Donors" },
{ "value": 0, "unit": "Tissue Types" },
{ "value": 0, "unit": "Assays" },
{ "value": 0, "unit": "Files Generated" }
]
}
]
}
]
}
return response
9 changes: 8 additions & 1 deletion src/encoded/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class MetadataArgs(NamedTuple):
accessions: List[str]
sort_param: str
type_param: str
status: str
include_extra_files: bool
download_file_name: str
header: Tuple[List[str], List[str], List[str]]
Expand Down Expand Up @@ -250,6 +251,7 @@ def handle_metadata_arguments(context, request):
accessions = post_params.get('accessions', [])
type_param = post_params.get('type')
sort_param = post_params.get('sort')
status = post_params.get('status')
cli = post_params.get('cli', False)
download_file_name = post_params.get('download_file_name')
include_extra_files = post_params.get('include_extra_files', False)
Expand All @@ -260,6 +262,7 @@ def handle_metadata_arguments(context, request):
accessions = json.loads(post_params.get('accessions', ''))
type_param = post_params.get('type')
sort_param = post_params.get('sort')
status = post_params.get('status')
cli = post_params.get('cli', False)
download_file_name = post_params.get('download_file_name')
include_extra_files = post_params.get('include_extra_files', False)
Expand All @@ -277,7 +280,7 @@ def handle_metadata_arguments(context, request):
# Note that this will become more complex as we add additional header types
header = generate_file_download_header(download_file_name, cli=cli)
tsv_mapping = TSV_MAPPING[FILE]
return MetadataArgs(accessions, sort_param, type_param, include_extra_files, download_file_name, header,
return MetadataArgs(accessions, sort_param, type_param, status, include_extra_files, download_file_name, header,
tsv_mapping, cli)


Expand All @@ -303,6 +306,8 @@ def peek_metadata(context, request):
search_param['accession'] = args.accessions
if args.sort_param:
search_param['sort'] = args.sort_param
if args.status:
search_param['status'] = args.status
search_param['limit'] = [1] # we don't care about results, just the facets
search_param['additional_facet'] = ['file_size']
if args.include_extra_files:
Expand Down Expand Up @@ -337,6 +342,8 @@ def metadata_tsv(context, request):
search_param['accession'] = args.accessions
if args.sort_param:
search_param['sort'] = args.sort_param
if args.status:
search_param['status'] = args.status
cli = args.cli
search_iter = get_iterable_search_results(request, param_lists=search_param)

Expand Down
56 changes: 50 additions & 6 deletions src/encoded/schemas/file.json
Original file line number Diff line number Diff line change
Expand Up @@ -225,22 +225,66 @@
}
},
"facets": {
"access_status": {
"title": "Access"
},
"donors.display_title": {
"title": "Donor",
"search_type": "sayt",
"sayt_item_type": "Donor"
},
"donors.age": {
"title": "Donor Age",
"aggregation_type": "range",
"number_step": 1,
"ranges": [
{
"from": 18,
"to": 30
},
{
"from": 30,
"to": 55
},
{
"from": 55,
"to": 65
},
{
"from": 65
}
]
},
"file_sets.libraries.analytes.samples.sample_sources.donor.sex": {
"title": "Donor Sex"
},
"sample_summary.tissues": {
"title": "Tissue"
},
"file_sets.libraries.assay.display_title": {
"title": "Experimental Assay"
"title": "Experimental Assay",
"search_type": "sayt",
"sayt_item_type": "Donor"
},
"file_sets.sequencing.sequencer.display_title": {
"title": "Sequencing Platform"
},
"donors.display_title": {
"title": "Donor",
"default_hidden": true
},
"file_format.display_title": {
"title": "Data Format"
},
"data_type": {
"data_category": {
"title": "Data Category"
},
"data_type": {
"title": "Data Type"
},
"reference_genome.display_title": {
"title": "Reference Genome"
},
"date_created": {
"title" : "Release Date",
"aggregation_type" : "stats"
},
"sequencing_center.display_title": {
"title": "Sequencing Center"
},
Expand Down
Loading
Loading