-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bm browse view #305
Merged
Merged
Bm browse view #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@utku-ozturk Could you double check that the google analytics implementation will work as expected here. I'm basically just re-using the download modal from benchmarking, so if there might be issues with that, let me know. |
crfmc
approved these changes
Jan 23, 2025
src/encoded/static/components/browse/browse-view/BrowseSummaryStatController.js
Outdated
Show resolved
Hide resolved
src/encoded/static/components/browse/browse-view/BrowseViewAboveFacetListComponent.js
Outdated
Show resolved
Hide resolved
src/encoded/static/components/navigation/components/BigDropdown/BigDropdownBigLink.js
Show resolved
Hide resolved
willronchetti
force-pushed
the
bm-browse-view
branch
from
January 23, 2025 18:41
e3edb1c
to
1027ef4
Compare
Bianca-Morris
changed the base branch from
dmichaels-20241119-browse-view
to
main
January 23, 2025 19:47
utku-ozturk
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
browse.py
, addedsample_summary.studies=Production&status=released
to base query. Removedadditional_facets
, since defining those inFile.json
metadata.py
, addedstatus
facet support to/peek_metadata
file.json
added/re-ordered various facets.App.js
:scrolledPast460
bit of state + class to body to make styling accommodations for larger space above table onBrowseView
.context.@atype[0]
as a data attribute on body; to make it easier to adjust styling on pages with server render errorsBrowseView.js
:BrowseView
(Note: may be worth re-addingDetailPaneStateCache
in future for performance; need to test with more data to see if it'll be necessary)filteredFilters
methodBigDropdownBigLink
here from 4DNBrowseViewControllerWithSelections
- right now this is basically a copy ofTableControllerWithSelections
. I anticipate this might change enough in the future to justify having it in a separate component - if that day doesn't come, feel free to merge them.BrowseView
only facets from benchmarkingSlidingSidebarLayout
componentSlidingSidebarLayout
, similar/types/
to add embeds for various fields needed for facets and columns.Required SPC PRs:
Related Trello Ticket:
Screenshots (out of date as of Jan 23):