Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bm browse view #305

Merged
merged 76 commits into from
Jan 23, 2025
Merged

Bm browse view #305

merged 76 commits into from
Jan 23, 2025

Conversation

Bianca-Morris
Copy link
Collaborator

@Bianca-Morris Bianca-Morris commented Dec 12, 2024

Changelog:

  • In browse.py, added sample_summary.studies=Production&status=released to base query. Removed additional_facets, since defining those in File.json
  • In metadata.py, added status facet support to /peek_metadata
  • In file.json added/re-ordered various facets.
    • Note: There are still a few facets and facet groupings to add. We don't have fields for everything available yet, so I will be adding these as they become available.
  • In App.js:
    • added a scrolledPast460 bit of state + class to body to make styling accommodations for larger space above table on BrowseView.
    • also added context.@atype[0] as a data attribute on body; to make it easier to adjust styling on pages with server render errors
  • In BrowseView.js:
    • Removed a bunch of old CGAP stuff from BrowseView (Note: may be worth re-adding DetailPaneStateCache in future for performance; need to test with more data to see if it'll be necessary)
    • Removed unused filteredFilters method
    • Updated with new layout for browse statistics, table, etc.
      • Note: Some things here are a bit repetitive from benchmarking (Esp. colextmap stuff. Waiting for this to become more stable to merge together into main colextmap.)
    • Reworked component for page title and breadcrumbs
  • Added various components in browse > browse-view for use in BrowseView (I know, very creative naming)
  • Moved a copy of BigDropdownBigLink here from 4DN
    • Did make some changes to this that are smaht-specific... will be worth reviewing BigDropdown in future to see if the edits made across the portals are different enough to justify not putting this in SPC
    • Used this in new version of data tab
  • Made a BrowseViewControllerWithSelections - right now this is basically a copy of TableControllerWithSelections. I anticipate this might change enough in the future to justify having it in a separate component - if that day doesn't come, feel free to merge them.
  • Hid a bunch of BrowseView only facets from benchmarking
  • Broke down benchmarking layout and UI components into generic SlidingSidebarLayout component
  • A variety of styling fixes for weirdness with various error pages and views, usually caused by SlidingSidebarLayout, similar
  • Made some changes in /types/ to add embeds for various fields needed for facets and columns.

Required SPC PRs:

Related Trello Ticket:

Screenshots (out of date as of Jan 23):
Browse View
Navigation Updates

@Bianca-Morris
Copy link
Collaborator Author

@utku-ozturk Could you double check that the google analytics implementation will work as expected here. I'm basically just re-using the download modal from benchmarking, so if there might be issues with that, let me know.

@Bianca-Morris Bianca-Morris changed the base branch from dmichaels-20241119-browse-view to main January 23, 2025 19:47
@Bianca-Morris Bianca-Morris merged commit 112b9c8 into main Jan 23, 2025
2 checks passed
@Bianca-Morris Bianca-Morris deleted the bm-browse-view branch January 23, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants