Fixes #7 Refactoring the criterion tests to libcheck #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 26, 2019 23:40
…avis, to download possible travis error with gcc6 in OSX
…ake test , but updating the xcode version to 8.0=>8.3
… stdevAlDen_t7_refactor_in_tests
added 2 commits
April 27, 2019 00:19
…sh, and declare to install gcc 6 `brew install gcc6` by testing in travis
added 7 commits
April 27, 2019 00:30
…avis-ci.com/skycoin/libskycoin/jobs/196050490#L1430, `error: ‘for’ loop initial declarations are only allowed in C99 mode`
…/travis-ci.org/skycoin/libskycoin/jobs/525238852#L1266 the type `error: ‘for’ loop initial declarations are only allowed in C99 mode`
olemis
reviewed
May 1, 2019
| @@ -17,7 +15,7 @@ | |||
| #define JSON_FILE_SIZE 4096 | |||
| #define JSON_BIG_FILE_SIZE 32768 | |||
|
|
|||
| // FIXME: Does not work on e.g. Windowa | |||
| // FIXME: Does not work on e.g. Windows | |||
There was a problem hiding this comment.
For the moment this will be tolerated ... full Windows support deferred until 0.26.0 .
…/cgo/skyassert.h
olemis
reviewed
May 1, 2019
lib/cgo/cipher.crypto.go
Outdated
| @@ -43,36 +43,6 @@ func SKY_cipher_PubKeyFromHex(_s string, _arg1 *C.cipher__PubKey) (____error_cod | |||
| return | |||
| } | |||
|
|
|||
| //export SKY_cipher_PubKeyFromSecKey | |||
There was a problem hiding this comment.
@stdevHan why is this removed ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Revert that change . That makes it impossible to auto-generate code out of skycoin/skycoin function signatures.
olemis
reviewed
May 1, 2019
lib/cgo/cipher.crypto.go
Outdated
| @@ -229,18 +176,6 @@ func SKY_cipher_GenerateKeyPair(_arg0 *C.cipher__PubKey, _arg1 *C.cipher__SecKey | |||
| return | |||
| } | |||
|
|
|||
| //export SKY_cipher_GenerateDeterministicKeyPair | |||
There was a problem hiding this comment.
olemis
suggested changes
May 1, 2019
lib/cgo/cipher.hash.go
Outdated
| @@ -59,14 +61,6 @@ func SKY_cipher_SHA256_Xor(_g *C.cipher__SHA256, _b *C.cipher__SHA256, _arg1 *C. | |||
| return | |||
| } | |||
|
|
|||
| //export SKY_cipher_SumSHA256 | |||
| func SKY_cipher_SumSHA256(_b []byte, _arg1 *C.cipher__SHA256) (____error_code uint32) { | |||
There was a problem hiding this comment.
olemis
suggested changes
May 5, 2019
lib/cgo/libsky_handle.go
Outdated
| @@ -467,39 +339,34 @@ func SKY_handle_close(handle C.Handle) { | |||
| closeHandle(Handle(handle)) | |||
| } | |||
|
|
|||
| //export SKY_handle_copy | |||
There was a problem hiding this comment.
can't remove this ... If I recall correctly it is used by SWIG extensions .
olemis
suggested changes
May 5, 2019
lib/cgo/cipher.crypto.hw.go
Outdated
| @@ -0,0 +1,150 @@ | |||
| package main | |||
There was a problem hiding this comment.
Put these back to their original location . This makes it impossible to auto-generate code out of skycoin/skycoin function signatures. Find another way to get this done .
…on.c => libsky_assert.c}
…ing them where they belong compared to `v0.25dev`.
olemis
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Changes:
Does this change need to mentioned in CHANGELOG.md?
yes
Requires testing
no