Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor libskycoin assert ref #t108 #2

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Refactor libskycoin assert ref #t108 #2

merged 4 commits into from
Sep 17, 2019

Conversation

stdevAlDen
Copy link

Fixes skycoin#108

Changes:

  • fix some function signatures from libskycoin.h
  • move TestSumSHA256 out of hw tests
  • move out of common some no available function in hw for libskycoin_assert

Does this change need to mentioned in CHANGELOG.md?
no

Requires testing
no

@stdevAlDen stdevAlDen added the enhancement New feature or request label Sep 10, 2019
@stdevAlDen stdevAlDen self-assigned this Sep 10, 2019
Merge remote-tracking branch 'simelo/stdevHan_t105_update_submodule_0…
ca974af 
….27.0' into stdevAlDen_t108_refactor_libskycoin_assert

Conflicts:
	lib/cgo/tests/testutils/libsky_assert.common.c
ref skycoin#108
@stdevMac stdevMac merged commit fd700e0 into stdevHan_t105_update_submodule_0.27.0 Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdevMac stdevMac stdevMac approved these changes

@m4yk3ldev m4yk3ldev Awaiting requested review from m4yk3ldev

Assignees

@stdevAlDen stdevAlDen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stdevAlDen @stdevMac