Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor in tests #7

Closed
stdevAlDen opened this issue Jan 24, 2019 · 2 comments
Closed

Refactor in tests #7

stdevAlDen opened this issue Jan 24, 2019 · 2 comments
Assignees
@olemis @stdevAlDen @m4yk3ldev
Labels
ci Tests and continuous integration stdev wip Work in progress
Milestone
0.25.1

Comments

@stdevAlDen
Copy link

Define an interface implemented by check, criterion or any other you want.
This is related to the need of use the same tests battery in libskycoin and hardware wallet.
@olemis olemis added stdev wip Work in progress ci Tests and continuous integration labels Jan 25, 2019
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jan 25, 2019
Merge remote-tracking branch 'simelo/olemis_t1_skycoin_submod' into s…
c662440 
…tdevAlDen_t7_refactor_in_tests ref skycoin#7
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jan 25, 2019
add assert member to xUnitTest struct ref skycoin#7
7379f9d
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jan 25, 2019
create_test_framework_wrapper for crterium ref skycoin#7
c9022c4
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jan 25, 2019
moved TestAddressNull to shared test to e usedd in hardware-wallet to…
a5dfd84 
…o ref skycoin#7
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jan 25, 2019
refactor some functions in a seprate file to be ignored in cgo stage,
30fa046 
some others will be used from hardware-walled/skycoin-api.

Functions mapping(in this commnt): a commented function in go is related
to is related to the one immediately below

// extern GoUint32 SKY_cipher_PubKeyFromSig(cipher__Sig* p0, cipher__SHA256* p1, cipher__PubKey* p2);
int recover_pubkey_from_signed_message(const char* message, const uint8_t* signature, uint8_t* pubkey);

void ecdsa_get_public_key33(const ecdsa_curve *curve, const uint8_t *priv_key, uint8_t *pub_key);
// const curve_info *get_curve_by_name(const char *curve_name);
// int hdnode_from_seed(const uint8_t *seed, int seed_len, const char* curve, HDNode *out);
// void hdnode_fill_public_key(HDNode *node);
void create_node(const char* seed_str, HNode* node);
void uncompress_mcoords(const ecdsa_curve *curve, uint8_t odd, const bignum256 *x, bignum256 *y);
int mecdsa_validate_pubkey(const ecdsa_curve *curve, const curve_point *pub);
void mpoint_multiply(const ecdsa_curve *curve, const bignum256 *k, const curve_point *p, curve_point *res);
void mscalar_multiply(const ecdsa_curve *curve, const bignum256 *k, curve_point *res);
void mpoint_set_infinity(curve_point *p);
int mpoint_is_infinity(const curve_point *p);
void mpoint_add(const ecdsa_curve *curve, const curve_point *cp1, curve_point *cp2);
// extern GoUint32 SKY_handle_copy(Handle p0, Handle* p1);
void mpoint_copy(const curve_point *cp1, curve_point *cp2);
int mpoint_is_equal(const curve_point *p, const curve_point *q);
int mpoint_is_negative_of(const curve_point *p, const curve_point *q);
// extern GoUint32 SKY_cipher_DoubleSHA256(GoSlice p0, cipher__SHA256* p1);
void mpoint_double(const ecdsa_curve *curve, curve_point *cp);
void mcurve_to_jacobian(const curve_point *p, jacobian_curve_point *jp, const bignum256 *prime);
void mjacobian_to_curve(const jacobian_curve_point *jp, curve_point *p, const bignum256 *prime);
void mpoint_jacobian_add(const curve_point *p1, jacobian_curve_point *p2, const ecdsa_curve *curve);
void mconditional_negate(uint32_t cond, bignum256 *a, const bignum256 *prime);
void mpoint_jacobian_double(jacobian_curve_point *p, const ecdsa_curve *curve);

// extern GoUint32 SKY_cipher_ECDH(cipher__PubKey* p0, cipher__SecKey* p1, coin__UxArray* p2);
void ecdh(const uint8_t* secret_key, const uint8_t* remote_public_key, uint8_t* ecdh_key /*should be size SHA256_DIGEST_LENGTH*/);
void ecdh_shared_secret(const uint8_t* secret_key, const uint8_t* remote_public_key, uint8_t* shared_secret /*should be size SHA256_DIGEST_LENGTH*/);
// extern GoUint32 SKY_cipher_SHA256_Set(cipher__SHA256* p0, GoSlice p1);
void secp256k1Hash(const uint8_t* seed, const size_t seed_length, uint8_t* secp256k1Hash_digest);
void generate_deterministic_key_pair_iterator(const uint8_t* seed, const size_t seed_length, uint8_t* nextSeed, uint8_t* seckey, uint8_t* pubkey);
// extern GoUint32 SKY_cipher_SumSHA256(GoSlice p0, cipher__SHA256* p1);
void compute_sha256sum(const uint8_t *seed, uint8_t* digest /*size SHA256_DIGEST_LENGTH*/, size_t seed_lenght);
// extern GoUint32 SKY_cipher_PubKeyFromSecKey(cipher__SecKey* p0, cipher__PubKey* p1);
void generate_pubkey_from_seckey(const uint8_t* seckey, uint8_t* pubkey);
// extern GoUint32 SKY_cipher_GenerateDeterministicKeyPair(GoSlice p0, cipher__PubKey* p1, cipher__SecKey* p2);
void generate_deterministic_key_pair(const uint8_t* seed, const size_t seed_length, uint8_t* seckey, uint8_t* pubkey);
// extern GoUint32 SKY_cipher_AddressFromPubKey(cipher__PubKey* p0, cipher__Address* p1);
void generate_base58_address_from_pubkey(const uint8_t* pubkey, char* address, size_t *size_address);
// extern void SKY_cipher_BitcoinAddressFromPubKey(cipher__PubKey* p0, cipher__BitcoinAddress* p1);
void generate_bitcoin_address_from_pubkey(const uint8_t* pubkey, char* address, size_t *size_address);
// extern GoUint32 SKY_cipher_BitcoinAddressFromSecKey(cipher__SecKey* p0, cipher__BitcoinAddress* p1);
void generate_bitcoin_private_address_from_seckey(const uint8_t* pubkey, char* address, size_t *size_address);
int ecdsa_skycoin_sign(const uint32_t nonce_value, const uint8_t *priv_key, const uint8_t *digest, uint8_t *sig);
// extern GoUint32 SKY_base58_String2Hex(GoString p0, coin__UxArray* p1);
void tohex(char * str, const uint8_t* buffer, int bufferLength);
// extern GoUint32 SKY_cipher_SecKeyFromHex(GoString p0, cipher__SecKey* p1);
void writebuf_fromhexstr(const char *str, uint8_t* buf);

ref skycoin#7
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jan 25, 2019
refactor lib/cgo/cipher.crypto.hw.go, move import "C" to the top ref s…
2770fe5 
…kycoin#7
@olemis
Copy link
Contributor

olemis commented Feb 3, 2019

@stdevHan pls continue the work done for this issue .

@olemis olemis added this to the 0.25.1 milestone Feb 10, 2019
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Feb 25, 2019
refs skycoin#7 Refactoring the criterion tests to libcheck
014d393
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Feb 25, 2019
refs skycoin#7 commented function already defined in another cgo.
27e9c74
@m4yk3ldev m4yk3ldev mentioned this issue Feb 25, 2019
Merged
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[CHANGELOG] refs skycoin#7 Putting in the position that corresponds t…
ea7d570 
…o the definition of changes
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis][Makefile] refs skycoin#7 Adding in the definition of install…
d221c5d 
…ation of the dependencies for libc to check and removing the rest
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Remove the env CC=gcc-6 in the test run by tr…
87ea8e6 
…avis, to download possible travis error with gcc6 in OSX
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Restore the previous configurations in test m…
b154076 
…ake test , but updating the xcode version to 8.0=>8.3
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Comment all definition in install-travis-gcc.…
368020e 
…sh, and declare to install gcc 6 `brew install gcc6` by testing in travis
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Define CC and CXX to env global
1780f8a
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Remove all test and only make check
4cc273e
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Restore install-travis-gcc.sh
7c8d884
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Remove CC and CXX in global env
9b5e097
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[libc] refs skycoin#7 Repair error in gcc 4.8 in GNU/Linux https://tr…
d0a1634 
…avis-ci.com/skycoin/libskycoin/jobs/196050490#L1430, `error: ‘for’ loop initial declarations are only allowed in C99 mode`
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[test] refs skycoin#7 Correcting errors reported by travis in https:/…
5c5d072 
…/travis-ci.com/skycoin/libskycoin/jobs/196051236#L1330
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[test] refs skycoin#7 Correcting errors reported by travis in https:/…
c285530 
…/travis-ci.org/skycoin/libskycoin/jobs/525238852#L1266 the type `error: ‘for’ loop initial declarations are only allowed in C99 mode`
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue Apr 27, 2019
[travis] refs skycoin#7 Upgrade dist trusty => xenial
12087ce
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 1, 2019
@olemis
[include] [cgo] refs skycoin#7 - Rename lib/cgo/skycriterion.h => lib…
aaa837b 
…/cgo/skyassert.h
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 1, 2019
@olemis
[libc] refs skycoin#7 - Remove splitCliArgs
f89926a
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 1, 2019
@olemis
[include] refs skycoin#7 - Consistent header guard names
cf4f310
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue May 1, 2019
[include] refs skycoin#7 Deleting unnecessary comment on `cipher.test…
787daa2 
…suite.testsuite.go.h

`
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 5, 2019
@olemis
[cgo] refs skycoin#7 - Rename lib/cgo/tests/testutils/{libsky_criteri…
ca8ae56 
…on.c => libsky_assert.c}
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue May 5, 2019
[CHANGELOG] refs skycoin#7 Restore to v0.25dev
6e36dc8
m4yk3ldev pushed a commit to simelo/libskycoin.orig that referenced this issue May 5, 2019
[cgo] refs skycoin#7 Restoring functions defined in CGO, incorporat…
06e7596 
…ing them where they belong compared to `v0.25dev`.
olemis added a commit that referenced this issue May 5, 2019
@olemis
Merge pull request #24 from simelo/stdevAlDen_t7_refactor_in_tests
47f8d0f 
Fixes #7 Refactoring the criterion tests to libcheck
@olemis
Copy link
Contributor

olemis commented May 5, 2019

fixed in 47f8d0f

@olemis olemis closed this as completed May 5, 2019
@vidya88 vidya88 mentioned this issue Sep 20, 2019
Open
@isaacvr isaacvr mentioned this issue Oct 31, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemis olemis

@stdevAlDen stdevAlDen

@m4yk3ldev m4yk3ldev

Labels
ci Tests and continuous integration stdev wip Work in progress
Projects
None yet
Milestone
0.25.1
Development

No branches or pull requests
3 participants
@olemis @stdevAlDen @m4yk3ldev